Re: [platform-swt-dev] Drag and drop update

[Steve Northover <Steve_Northover@xxxxxxxxxx>]

The issue with "*" vs. "non-*"
is big when you are on the top of the stack.  In that case, when you
use "*", new classes could be added to a package that you import
and you'll get a conflict without changing a line of code (bad).  SWT
uses "*" because it is on the bottom of the stack and doesn't
have the problem.  I don't think it makes much difference (if any)
to the compiler.

About the comment thing, I was personally
taken aside and beaten over it and that's why I'm sensitive.  That
was a long time ago, but the scars are deep.  Perhaps it's time to
"let go".

Scott Kovatch <skovatch@xxxxxxxxx>
Sent by: platform-swt-dev-bounces@xxxxxxxxxxx

09/25/2008 04:43 PM

Please respond to
"Eclipse Platform SWT component developers list."        <platform-swt-dev@xxxxxxxxxxx>

To	"Eclipse Platform SWT component developers list." <platform-swt-dev@xxxxxxxxxxx>
cc
Subject	Re: [platform-swt-dev] Drag and drop update

On 9/25/08 11:31 AM, "Steve Northover" <Steve_Northover@xxxxxxxxxx>
wrote:

> Thanks Scott.  I looked through the code quicky for leaks etc.
and it looked
> good.  I'm getting Duong to run it and test it a bit.  I'm
very happy!
> 
> A couple of very small style points.  As we are on the bottom
of the tool
> stack, we import * rather than each individual class (Eclipse preferences
can
> be set to do this).

On the imports, I just let Eclipse manage them for me automatically, so
it's
no big deal for me one way or the other.  I've worked on projects
where the
lead took the exact opposite position on the "*" vs. individual
import lines
because (I was told) 'it's easier on the compiler', which I never bought,
and even if it was, I don't think it's slowing down the compiler enough
to
make a difference.

You mentioned the Eclipse preferences, but a broader question I have is
whether or not you guys have a standard set of compiler settings or project
preferences we should all use?  We have that on Thermo, and it's very
helpful when setting up a new workspace or when a new person starts.  You
just import a file of settings and you don't have to think about it again.

> Also, in a comment, we would never use the word "snarf"
> (although there is nothing really wrong with it as far as I can see).

> After a few iterations of this (and the time that it wasted, both
mine and the
> reviewer), I vowed "never again".  The result was ...
well, boring software,
> but all software is boring in some sense.  The upside was that
I never had to
> ask the question, "Is there anything bad in the comments in the
code".

That's pretty sad.  I understand looking out for personal snipes,
vulgarities or other inappropriate wording, but changing comments because
you didn't like the tone?  Come on.  But, I see your point.
 
> So, what do you think?  Like many things, it's defacto SWT policy
to be really
> formal in comments, even avoiding the word "I".

The only time I would ever leave my name or a personal pronoun in a comment
like that is if I checked in something that I wasn't sure about and wanted
to leave a note for future readers of the code.  Once the ambiguity
or
problem is resolved, it should go away.

I'm okay with the comment policy, but I also think I tend to be more verbose
than you guys.  As for "snarf", that doesn't sound like
I word I would have
used, but I could be wrong. :-) I'll keep all this in mind as I'm fixing
bugs and writing new stuff.

Scott

--------------- 
Scott Kovatch
Flex Engineering
Adobe Systems, Inc.
skovatch@xxxxxxxxx

I am Scott Kovatch, and I approved this message.

_______________________________________________
platform-swt-dev mailing list
platform-swt-dev@xxxxxxxxxxx
https://dev.eclipse.org/mailman/listinfo/platform-swt-dev