Re: [platform-swt-dev] Patch for SWT_AWT

[Veronika_Irvine@xxxxxxx]

You are correct.

I compiled against JDK 1.3 and then ran with JDK 1.4.  The support of  AWT/Swing inside SWT still works but the support for SWT inside AWT/Swing is broken due to the missing sun.awt.DrawingSurface class.

I will have to consult to see what we shall do.  One solution is to remove the method SWT_AWT.new_Shell() since embedding SWT inside Swing is not interesting to eclipse.

BTW I actually do not think a version check is required as the AWT native interface was introduced in JDK 1.3.

Leonard Norrgard <lkn@xxxxxxx> Sent by: platform-swt-dev-admin@xxxxxxxxxxx 03/05/2002 10:24 AM Please respond to platform-swt-dev

To:        platform-swt-dev@xxxxxxxxxxx         cc:                 Subject:        Re: [platform-swt-dev] Patch for SWT_AWT

Veronika,

The code you checked in doesn't compiler under 1.4, as it uses the 
unpublished and now removed sun.awt.DrawingSurface class (see Java 1.4.0 
docs). The replacement is the published, new JAWT interface to AWT for 
native programs. What Matt's code does is to use this new interface in 
the new_Shell method to get the needed hWnd to the drawing surface.

In order to have the same Eclipse installation run with either Java RE, 
a version check has to be added (together with introspective method 
invocations).

-- Leonard

Veronika_Irvine@xxxxxxx wrote:
> 
> Thank you for the patch.
> 
> We have looked at the code and it seems fine but it does not appear to 
> do anything different from what we are already doing in Java code.
> We found a problem with our Java implementation in JDK 1.4 and have 
> fixed this so you should be able to run on JDK 1.4 using the latest 
> integration build (20020501-I).
> 
> We will hang on to your patch but we will not be releasing the changes 
> until after 2.0 when we have more time to test on the various platforms 
> and examine the issues.
> 
> Thank you,
> Veronika
> 
> 
> 
> *"Di Iorio, Matthew (ISS Atlanta)" <MDiIorio@xxxxxxx>*
> Sent by: platform-swt-dev-admin@xxxxxxxxxxx
> 
> 26/04/2002 03:24 PM
> Please respond to platform-swt-dev
> 
>        
>         To:        "'platform-swt-dev@xxxxxxxxxxx'" 
> <platform-swt-dev@xxxxxxxxxxx>
>         cc:        
>         Subject:        RE: [platform-swt-dev] Patch for SWT_AWT
> 
> 
> 
> 
> 
> I have tested with JDK  1.3 and 1.4 and Windows 2000.  All of the 
> knowledge/code was taken from the  following page, which is included in 
> the JDK 1.3 docs:
> 
> _http://java.sun.com/j2se/1.3/docs/guide/awt/AWT_Native_Interface.html_
> 
> The code only works  with Windows because (a) I don't know  too much 
> about X and (b) I don't  have Linux installed anywhere.  It shouldn't 
>  be too hard to port to X if there is a way to create a Shell from a 
>  Drawable(?).
>  
> The only quirk with the code is the part that loads jawt.dll(the 
> loadJawtLibrary  function).  Duringtesting I found that the code failed 
> to load  jawt.dll when the code was run using the invocation API.  When 
> I ran the code with java.exe it  worked fine.  I'm not sure if  it's 
> something that I am doing wrong, but I haven't figured out a way around 
>  it.
>  
> Matt
> -----Original Message-----
> *From:* Veronika_Irvine@xxxxxxx  [mailto:Veronika_Irvine@xxxxxxx]
> *Sent:* Friday, April 26, 2002 8:43  AM
> *To:* platform-swt-dev@xxxxxxxxxxx
> *Subject:* Re:  [platform-swt-dev] Patch for SWT_AWT
> 
> 
> Cool.  What JDK versions does it work with and  what OS platforms have 
> you tested it on?
> 
> The file swt.c is generally for native OS calls so we would probably 
>  keep the AWT integration native stuff seperate as I assume it is 
>   platform independant.
> 
> Send  the patch to this mailing list and we will check it out.  Before 
> sending  a patch, please be sure that it does not include any code that 
> is copied from  AWT source that is not publicly available and that it 
> does not make use of any  knowledge of AWT that is not publicly available.
> 
> Thank you,
> Veronika
> 
> 
> 
> *"Di Iorio, Matthew (ISS Atlanta)"  <MDiIorio@xxxxxxx>*
> Sent by: platform-swt-dev-admin@xxxxxxxxxxx  
> 
> 25/04/2002 05:52 PM
> Please respond to platform-swt-dev  
>        
>         To:         "'platform-swt-dev@xxxxxxxxxxx'" 
>  <platform-swt-dev@xxxxxxxxxxx>
>         cc:         
>          Subject:        [platform-swt-dev] Patch for  SWT_AWT
> 
> 
> 
> I  have version of the SWT_AWT class using JAWT that I wanted to 
>  contribute.
> Part of the class is implemented natively and I'm not quite  sure how that
> fits into the Eclipse project.  Would the native part be  patched into the
> swt.c file?  Right now I have it in its own  file.
> 
> Thanks,
> 
> -- 
> Matt Di Iorio                 Software Engineer
> mdiiorio@xxxxxxx          Phone: (404) 236-2748
> Internet Security Systems  (http://www.iss.net)
> 
> _______________________________________________
> platform-swt-dev  mailing  list
> platform-swt-dev@xxxxxxxxxxx
> http://dev.eclipse.org/mailman/listinfo/platform-swt-dev
> 
> 
> 
> 
> 




_______________________________________________
platform-swt-dev mailing list
platform-swt-dev@xxxxxxxxxxx
http://dev.eclipse.org/mailman/listinfo/platform-swt-dev