[platform-swt-dev] RE: AIX port of SWT

[johnrose@xxxxxxxxxxxxxx]

Kevin-

Agreed that it would be nice to specify VM arguments in the makefiles.  The
problem in the AIX case is that this particular argument can only be appended
for users with a certain Java VM version.

I have attached the code that I have thrown together for this problem, and I'd
like to hear your thoughts.  The modifications are made from the 0214 build,
and they affect:
	library/eclipse.c
	library/eclipseMotif.c
	library/eclipseOS.h
	library/make_aix.mak

Thanks-
John

----------------
John Rose
AIX Kernel Development
johnrose@xxxxxxxxxxxxxx
Office: 512-838-0298
Tieline: 678-0298


On Fri, 22 Mar 2002, Cornell, Kevin wrote:

> John:
>
> Send me a ZIP file of the changes and I will look them over. There should be
> a way to have the OS specific makefiles specify special VM arguments and
> have the launcher itself more generic (less #ifdef code).
>
> Kevin
>
> -----Original Message-----
> From: johnrose@xxxxxxxxxxxxxx [mailto:johnrose@xxxxxxxxxxxxxx]
> Sent: March 21, 2002 5:24 PM
> To: kcornell@xxxxxxxxxxxx
> Cc: amackay@xxxxxxxxxx; Mike_Wilson@xxxxxxx
> Subject: AIX port of SWT
>
> Kevin-
>
> Mike Wilson mentioned that you have been doing most of the launcher work for
> Eclipse.  I wanted to get your thoughts on some of the changes we've added
> to
> our private build of the launcher code for the AIX case.
>
> Eclipse users on AIX will use one of two Java VM's, IBM's Java 1.3.0 or
> 1.3.1.
> The IBM Java people have added a command-line argument for VM 1.3.1 that
> optimizes JIT activity for GUI applications.  Without this command-line
> argument, Eclipse with IBM Java 1.3.1 is *extremely* slow.  With the
> argument,
> it's 20-30 percent faster than 1.3.0.
>
> It is our view that we should not require Eclipse users who use Java 1.3.1
> to
> manually add this VM argument (eclipse -vmargs -Xquickstart ....), for two
> reasons: 1) Users either won't bother or won't know to use it, and 2) There
> will not be a case in which it is desirable not to use it.  As a result, I
> have
> added some code to the launcher source to append this argument to the list
> of
> VM args.
>
> Since the argument was not added until v1.3.1, use of this argument with
> 1.3.0
> results in a fatal error message. To avoid this, the changes check for the
> case
> of a Java VM greater than or equal to 1.3.1, and append the argument.  All
> of
> this code is ifdef'ed out for the AIX case.
>
> I understand that it would be nice to avoid dropping any more
> system-dependent
> code in the launcher src, but it is our thought that these changes are
> better than the alternative.  I would like to hear your thoughts on this,
> along
> with any suggestions on how to go about getting these changes made.
>
> Your help is appreciated-
> John
>
> ----------------
> John Rose
> AIX Kernel Development
> johnrose@xxxxxxxxxxxxxx
> Office: 512-838-0298
> Tieline: 678-0298
>
>

Attachment: launcherchanges.zip
Description: Zip archive