Skip to main content
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index] [List Home]
Re: [platform-releng-dev] 4.19 I-Build: I20210205-1800 - BUILD FAILED
The idea of offering a default method in the interface was rejected as it is marked with @noimplements.
If we see that this causes issues for more projects, we can still add an empty default implementation.

> Wouldn’t it have been better to have an IResource2 interface instead which added the method, so that downstream users could provide it if they needed to?

With Java default methods in Interface the "old way" of new interfaces seem not the best way to handle API enhancements.



On Sat, Feb 6, 2021 at 11:41 AM Alex Blewitt <alex.blewitt@xxxxxxxxx> wrote:
I’m not sure adding a method to IResource is a safe thing to do; how do we prevent breakages from all the other users that implement IResource in downstream projects?

Wouldn’t it have been better to have an IResource2 interface instead which added the method, so that downstream users could provide it if they needed to?

Alex

Sent from my iPhone 📱

On 6 Feb 2021, at 10:38, Lars Vogel <lars.vogel@xxxxxxxxxxx> wrote:


On Sat, Feb 6, 2021 at 11:32 AM Lars Vogel <lars.vogel@xxxxxxxxxxx> wrote:
I will fix that one in 2 mins

Sravan K Lakkimsetti <sravankumarl@xxxxxxxxxx> schrieb am Sa., 6. Feb. 2021, 11:17:

Build failed again

 

[ERROR] Failed to execute goal org.eclipse.tycho:tycho-compiler-plugin:2.2.0:compile (default-compile) on project org.eclipse.e4.tools.emf.ui: Compilation failure: Compilation failure:

[ERROR] /home/jenkins/agent/workspace/eclipse-aggregator-master/eclipse.platform.ui.tools/bundles/org.eclipse.e4.tools.emf.ui/src/org/eclipse/e4/tools/emf/ui/internal/common/component/dialogs/ContributionDataFile.java:[58]

[ERROR]         public class ContributionDataFile implements IFile {

[ERROR]                      ^^^^^^^^^^^^^^^^^^^^

[ERROR] The type ContributionDataFile must implement the inherited abstract method IResource.createMarker(String, Map<String,Object>)

[ERROR] -> [Help 1]

[ERROR]

[ERROR] To see the full stack trace of the errors, re-run Maven with the -e switch.

[ERROR] Re-run Maven using the -X switch to enable full debug logging.

[ERROR]

[ERROR] For more information about the errors and possible solutions, please read the following articles:

[ERROR] [Help 1] http://cwiki.apache.org/confluence/display/MAVEN/MojoFailureException

[ERROR]

[ERROR] After correcting the problems, you can resume the build with the command

[ERROR]   mvn <args> -rf :org.eclipse.e4.tools.emf.ui

 

Still investigating

 

Thanks

Sravan

 

From: Sravan K Lakkimsetti <sravankumarl@xxxxxxxxxx>
Sent: 06 February 2021 14:20
To: Eclipse platform release engineering list. <platform-releng-dev@xxxxxxxxxxx>
Subject: [EXTERNAL] Re: [platform-releng-dev] 4.19 I-Build: I20210205-1800 - BUILD FAILED

 

Triggered a test build https://ci.eclipse.org/platform/job/eclipse-aggregator-master/1340/console.

 

PS: This job can be used to build aggregator for verification purposes.

 

Thanks

Sravan

 

From: Lars Vogel <lars.vogel@xxxxxxxxxxx>
Sent: 06 February 2021 13:49
To: Eclipse platform release engineering list. <platform-releng-dev@xxxxxxxxxxx>
Subject: [EXTERNAL] Re: [platform-releng-dev] 4.19 I-Build: I20210205-1800 - BUILD FAILED

 

I added the missing method override in the test class via https://git.eclipse.org/r/c/platform/eclipse.platform.text/+/175914 and reapplied the patch.

 

Best regards, Lars

 

On Sat, Feb 6, 2021 at 6:52 AM Sravan K Lakkimsetti <sravankumarl@xxxxxxxxxx> wrote:

I reverted the fix done for Bug 570914 - Create API that allows marker creation with attributes and restarted a build now.

 

I sorry for the revert. I would have waited for a fix if it was a working day.

 

Thanks

Sravan

 

From: Jonah Graham <jonah@xxxxxxxxxxxxxxxx>
Sent: 06 February 2021 07:18
To: Eclipse platform release engineering list. <platform-releng-dev@xxxxxxxxxxx>
Subject: [EXTERNAL] Re: [platform-releng-dev] 4.19 I-Build: I20210205-1800 - BUILD FAILED

 

If it is helpful, I think the new method was added as part of https://bugs.eclipse.org/bugs/show_bug.cgi?id=570914

 


~~~
Jonah Graham
Kichwa Coders
www.kichwacoders.com

 

 

On Fri, 5 Feb 2021 at 20:28, Alex Blewitt <alex.blewitt@xxxxxxxxx> wrote:

23:56:25  [ERROR] Failed to execute goal org.eclipse.tycho:tycho-compiler-plugin:2.2.0:compile (default-compile) on project org.eclipse.text.quicksearch.tests: Compilation failure: Compilation failure: 
23:56:25  [ERROR] /home/jenkins/agent/workspace/I-build-4.19/eclipse.platform.releng.aggregator/eclipse.platform.releng.aggregator/cje-production/gitCache/eclipse.platform.releng.aggregator/eclipse.platform.text/org.eclipse.text.quicksearch.tests/src/org/eclipse/text/quicksearch/tests/MockResource.java:[37] 
23:56:25  [ERROR]     public class MockResource implements IResource {
23:56:25  [ERROR]                  ^^^^^^^^^^^^
23:56:25  [ERROR] The type MockResource must implement the inherited abstract method IResource.createMarker(String, Map<String,Object>)

 

Sent from my iPhone 📱

 

On 5 Feb 2021, at 23:56, genie.releng@xxxxxxxxxxx wrote:

Please go to https://ci.eclipse.org/releng/job/I-build-4.19/103/console and check the build failure.

_______________________________________________
platform-releng-dev mailing list
platform-releng-dev@xxxxxxxxxxx
To unsubscribe from this list, visit https://www.eclipse.org/mailman/listinfo/platform-releng-dev

_______________________________________________
platform-releng-dev mailing list
platform-releng-dev@xxxxxxxxxxx
To unsubscribe from this list, visit https://www.eclipse.org/mailman/listinfo/platform-releng-dev

 

_______________________________________________
platform-releng-dev mailing list
platform-releng-dev@xxxxxxxxxxx
To unsubscribe from this list, visit https://www.eclipse.org/mailman/listinfo/platform-releng-dev


 

--

Eclipse Platform project co-lead
CEO vogella GmbH

Haindaalwisch 17a, 22395 Hamburg
Amtsgericht Hamburg: HRB 127058
Geschäftsführer: Lars Vogel, Jennifer Nerlich de Vogel
USt-IdNr.: DE284122352
Fax (040) 5247 6322, Email: lars.vogel@xxxxxxxxxxx, Web: http://www.vogella.com

 


_______________________________________________
platform-releng-dev mailing list
platform-releng-dev@xxxxxxxxxxx
To unsubscribe from this list, visit https://www.eclipse.org/mailman/listinfo/platform-releng-dev


--
Eclipse Platform project co-lead
CEO vogella GmbH

Haindaalwisch 17a, 22395 Hamburg
Amtsgericht Hamburg: HRB 127058
Geschäftsführer: Lars Vogel, Jennifer Nerlich de Vogel
USt-IdNr.: DE284122352
Fax (040) 5247 6322, Email: lars.vogel@xxxxxxxxxxx, Web: http://www.vogella.com
_______________________________________________
platform-releng-dev mailing list
platform-releng-dev@xxxxxxxxxxx
To unsubscribe from this list, visit https://www.eclipse.org/mailman/listinfo/platform-releng-dev
_______________________________________________
platform-releng-dev mailing list
platform-releng-dev@xxxxxxxxxxx
To unsubscribe from this list, visit https://www.eclipse.org/mailman/listinfo/platform-releng-dev


--
Eclipse Platform project co-lead
CEO vogella GmbH

Haindaalwisch 17a, 22395 Hamburg
Amtsgericht Hamburg: HRB 127058
Geschäftsführer: Lars Vogel, Jennifer Nerlich de Vogel
USt-IdNr.: DE284122352
Fax (040) 5247 6322, Email: lars.vogel@xxxxxxxxxxx, Web: http://www.vogella.com

Back to the top