Thanks Dani,
I want to clarify the rules once again, may be I will put it somewhere in the wiki once we agreed.
So in order to push commit to R4_XX_maintenance branch, one must follow RC2 criteria, which are:
"All fixes submitted must have a project lead or PMC vote on the bug report, and the fix must be reviewed by an additional committer (any committer other than the one who made the fix). A positive review from a project lead or PMC member means implicit approval and no vote is needed on the bug report."
I read it this way:
1) On gerrit with backported patch ask for the "+1" review from or from PL/PMC or from a committer that was not the original patch owner.
The committer who backports the patch but is not the owner of the original patch, is also allowed to vote with "+1".
2) If the "+1" reviewer on gerrit is not PL/PMC, ask them in a comment on original bug for an explicit "+1" for backporting.
3) If 1) and 2) are successfully done, and tests are OK, gerrit can be merged.
4) API changes or new features backported require additionally explicit PMC approval.
Is this above right so far?
The only question regarding point 2) I have is: do we really need PL/PMC to be involved, even if we don't build anything from the sources and in theory nobody is at risk?
The PL/PMC vote is worrying me, looking on the number of JDT core fixes I've backported so far on 4.12 branch and the known lack of resources in JDT team.