Re: [platform-releng-dev] [eclipse-build]Build I20111209-0943 (Timestamp

[Daniel Megert <daniel_megert@xxxxxxxxxx>]

I completely agree with John: manual tagging
is dangerous. Not just because it can break the build, as we learned, and
not just because of the time stamp issue: one can also end up with bundles
not being tagged if they changed since the last build input and if the
new manual tag is not also assigned to them in the map file.

We already had the rule when building
against CVS: never manually tag - use the Releng tools. In the Git world
this means, let the auto-tagging do its work by itself.

>Although manual tagging shouldn't
generally be needed...
The known exception to this are the
ISV doc bundles because they need to be rebuilt when Javadoc or extension
point doc changes outside an ISV doc bundle. Our auto-tagging script does
not detect this (yet [2]). Instead of touching a "real" file
we could add a dummy file that can be changed to trigger a rebuild.

Ah, and of course no manual changes
should ever be made while a build is in progress. It looks like the message
that a build started is no longer sent [1].

Dani

[1] https://bugs.eclipse.org/366285
[2] https://bugs.eclipse.org/366287

From:	John Arthorne <John_Arthorne@xxxxxxxxxx>
To:	"Eclipse platform release engineering list." <platform-releng-dev@xxxxxxxxxxx>
Date:	10.12.2011 02:29
Subject:	Re: [platform-releng-dev] [eclipse-build]Build I20111209-0943        (Timestamp: 201112090943):Build is complete. Automated JUnit        testing is starting.

---

The root of the problem was manual tagging
done while the build was running. This caused the auto-tagging script to
run into a merge conflict when it tried to push its own map file changes.
The build should really fail at this point, I have entered a bug for that
[1]. The later failures were due to attempting to manually fix the first
problem. The cleanest approach in the case of any failure would be to just
wipe the repositories on the build machine and re-clone them. This is a
bit more expensive but I think in the end it is the safest answer.

I think we should also avoid any kind of manual changes to the map files
since it doesn't play well with automatic tagging. Automatic tags are computed
from UTC time of the last commit. If you tag manually you will probably
come up with something different, and there is a risk the version numbers
won't increment properly. Although manual tagging shouldn't generally be
needed, the safest way to do it would be to commit a trivial change in
that plugin (for example touch a file like build.properties that is not
included in the binary output). 

[1] https://bugs.eclipse.org/bugs/show_bug.cgi?id=366279

Daniel Megert <daniel_megert@xxxxxxxxxx>
Sent by: platform-releng-dev-bounces@xxxxxxxxxxx

12/09/2011 04:32 PM

Please respond to
"Eclipse platform release engineering list."        <platform-releng-dev@xxxxxxxxxxx>

To	"Eclipse platform release engineering list." <platform-releng-dev@xxxxxxxxxxx>
cc
Subject	Re: [platform-releng-dev] [eclipse-build]Build I20111209-0943        (Timestamp: 201112090943):Build is complete. Automated JUnit        testing is starting.

> Talked to Paul again. There was a problem with the local copy of the
doc 
repo. 

Can you provide more details. I would expect that the build process 
doesn't rely on local state but rather works on the server repository 
state.

Dani


platform-releng-dev-bounces@xxxxxxxxxxx wrote on 09.12.2011 20:55:36:

> From:
> 
> Kim Moir <Kim_Moir@xxxxxxxxxx>
> 
> To:
> 
> "Eclipse platform release engineering list." 
<platform-releng-dev@xxxxxxxxxxx>
> 
> Date:
> 
> 09.12.2011 20:56
> 
> Subject:
> 
> Re: [platform-releng-dev] [eclipse-build]Build I20111209-0943 
(Timestamp: 201112090943):Build is complete. Automated JUnit testing is
starting.
> 
> Talked to Paul again. There was a problem with the local copy of the
doc 
repo.  This has been fixed and I've started an integration build to
include the new SWT bundles. 
> 
> Kim 
> 
> 
> 
> From:        Deepak Azad <deepak.azad@xxxxxxxxxx>
> To:        "Eclipse platform release engineering
list." 
<platform-releng-dev@xxxxxxxxxxx> 
> Date:        12/09/2011 02:49 PM 
> Subject:        Re: [platform-releng-dev] [eclipse-build]Build
I20111209-0943        (Timestamp: 201112090943):Build
is complete. 
Automated JUnit        testing is starting. 
> Sent by:        platform-releng-dev-bounces@xxxxxxxxxxx
> 
> 
> 
> Something went wrong again :(
> 
> The last commit on Platform Common repository is not tagged
> http://git.eclipse.org/c/platform/eclipse.platform.common.git/
even 
though
> the commit seems to have happened at 2011-12-09 09:30:04 (EST).
> 
> Also the build includes the following 2 plugin versions, which are
quite
> old.
> - org.eclipse.jdt.doc.isv_3.8.0.v20111205-2016.jar
> - org.eclipse.jdt.doc.user_3.8.0.v20111205-0928.jar
> See also
> 
http://download.eclipse.org/eclipse/downloads/drops/I20111209-0943/directory.txt

> 
> While the previous build (I20111208-1305) had a newer version for
of
> org.eclipse.jdt.doc.isv plugin - v20111208-1301. See
> 
http://download.eclipse.org/eclipse/downloads/drops/I20111208-1305/directory.txt

> 
> Deepak
> 
> 
> 
> From:                 Kim_Moir@xxxxxxxxxx
> To:                 platform-releng-dev@xxxxxxxxxxx
> Date:                 12/09/2011
11:59 PM
> Subject:                 [platform-releng-dev]
[eclipse-build]Build 
I20111209-0943
>            (Timestamp: 201112090943):Build
is complete. Automated JUnit
>            testing is starting.
> Sent by:                 platform-releng-dev-bounces@xxxxxxxxxxx
> 
> 
> 
> Build I20111209-0943 (Timestamp: 201112090943):  The build is
complete.
> 
> HTTP Download:
> 
> http://download.eclipse.org/eclipse/downloads/drops/I20111209-0943
> 
> The Build is complete.  Automated JUnit testing is starting.
> 
> HTTP Download:
> 
> http://download.eclipse.org/eclipse/downloads/drops/I20111209-0943
> 
> 
> _______________________________________________
> platform-releng-dev mailing list
> platform-releng-dev@xxxxxxxxxxx
> https://dev.eclipse.org/mailman/listinfo/platform-releng-dev
> 
> 
> 
> _______________________________________________
> platform-releng-dev mailing list
> platform-releng-dev@xxxxxxxxxxx
> https://dev.eclipse.org/mailman/listinfo/platform-releng-dev
> 
> _______________________________________________
> platform-releng-dev mailing list
> platform-releng-dev@xxxxxxxxxxx
> https://dev.eclipse.org/mailman/listinfo/platform-releng-dev

_______________________________________________
platform-releng-dev mailing list
platform-releng-dev@xxxxxxxxxxx
https://dev.eclipse.org/mailman/listinfo/platform-releng-dev

_______________________________________________
platform-releng-dev mailing list
platform-releng-dev@xxxxxxxxxxx
https://dev.eclipse.org/mailman/listinfo/platform-releng-dev