RE: [platform-releng-dev] compiler warnings

[Philippe P Mulet <philippe_mulet@xxxxxxxxxx>]

This also feels like a (little) mistake
to me. I suspect the intention was to silence some warnings for test suites,
where code quality is a lesser focus.
+1 to remove the "suppress"
portion from the build settings.

"Walter Harley" <wharley@xxxxxxx>
Sent by: platform-releng-dev-bounces@xxxxxxxxxxx

11/12/2007 18:00

Please respond to
"Eclipse platform release engineering list."        <platform-releng-dev@xxxxxxxxxxx>

To	"Eclipse platform release engineering list." <platform-releng-dev@xxxxxxxxxxx>
cc
Subject	RE: [platform-releng-dev] compiler warnings

So I think that means that we
are disabling @SuppressWarnings in the test plug-ins, i.e., we are enabling
even those warnings that are intentionally suppressed.
 
That seems like a mistake to me?
 I think in test plugins we want to be tolerant.
 
I would like to request that we
get rid of the "suppress" for test plugins, if possible.
 
Thanks,
  -walter

---

From: platform-releng-dev-bounces@xxxxxxxxxxx
[mailto:platform-releng-dev-bounces@xxxxxxxxxxx] On Behalf Of Kim
Moir
Sent: Tuesday, December 11, 2007 6:49 AM
To: Eclipse platform release engineering list.
Subject: Re: [platform-releng-dev] compiler warnings


The compiler settings specified in the build.properties for the portion
of the builder that builds the test feature are 
-warn:-discouraged,forbidden,suppress

Kim

Philippe P Mulet <philippe_mulet@xxxxxxxxxx>
Sent by: platform-releng-dev-bounces@xxxxxxxxxxx

12/11/2007 09:18 AM

Please respond to
"Eclipse platform release engineering list."        <platform-releng-dev@xxxxxxxxxxx>

To	"Eclipse platform release engineering list." <platform-releng-dev@xxxxxxxxxxx>
cc
Subject	Re: [platform-releng-dev] compiler warnings

You can disable @SuppressWarnings using command line option:
"-warn:-suppress", so as for instance to revisit them all if
you'd like (by
default, @SuppressWarnings are enabled).
It feels almost like someone would have set this option off per accident
?

Just my 2 cents.



                    
                     
                     
         
            "Walter Harley"  
                     
                     
            <wharley@xxxxxxx>  
                     
                    
            Sent by:      
                     
                     
To 
            platform-releng-d    
    "Eclipse platform release        
  
            ev-bounces@eclips    
    engineering list."          
       
            e.org        
            <platform-releng-dev@xxxxxxxxxxx>
  
                    
                     
                     
      cc 
                    
                     
                     
         
            10/12/2007 23:38    
                     
           Subject 
                    
                 [platform-releng-dev]
compiler      
                    
                 warnings
                     
     
            Please respond to    
                     
                  
            "Eclipse platform  
                     
                    
                 release  
                     
                     
   
               engineering    
                     
                     
                 list."  
                     
                     
    
            <platform-releng-    
                     
                  
            dev@xxxxxxxxxxx>    
                     
                   
                    
                     
                     
         
                    
                     
                     
         




There are a lot of compiler warnings in the releng builds on
org.eclipse.jdt.apt.tests.  Specifically, I'm seeing "The local
variable
[xxx] is never read", even though there is an
@SuppressWarnings("unused") on the relevant classes; and I'm
seeing
"Type safety: Unchecked cast from [xxx] to [yyy]>", even though
there is
a @SuppressWarnings("unchecked").

These warnings do not appear in my local workspace.  I have default
settings for compiler warnings at the workspace level, and the project
does not have any project-specific setting.  My dev host environment
is
I20071101-0010, which I think == 3.4M3.  There are no -warn options
in
build.properties (viz. Andrew Niefer's mail to this list on 11/7/07).

Does anyone know why @SuppressWarnings would be getting ignored in test
plug-ins?

Thanks,
 -walter
_______________________________________________
platform-releng-dev mailing list
platform-releng-dev@xxxxxxxxxxx
https://dev.eclipse.org/mailman/listinfo/platform-releng-dev


_______________________________________________
platform-releng-dev mailing list
platform-releng-dev@xxxxxxxxxxx
https://dev.eclipse.org/mailman/listinfo/platform-releng-dev
_______________________________________________
platform-releng-dev mailing list
platform-releng-dev@xxxxxxxxxxx
https://dev.eclipse.org/mailman/listinfo/platform-releng-dev



Sauf indication contraire ci-dessus:
Compagnie IBM France
Siège Social : Tour Descartes, 2, avenue Gambetta, La Défense 5, 92400
Courbevoie
RCS Nanterre 552 118 465
Forme Sociale : S.A.S.
Capital Social : 542.737.118 €
SIREN/SIRET : 552 118 465 02430