Skip to main content

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index] [List Home]
Re: [platform-releng-dev] Translatable Attributes in manifest files

I was as alarmed as you are when I recently learned that some people
actually use these properties file to NL java code.
Not sure how this trend started, but it ought to be stopped.

PDE does not currenly flag plugin.properties keys that are not be used in
manifest files.

Such a feature is a 3.2 candidate for PDE along with an NLS wizard for
manifest files.

What we currently flag however is keys in your plugin.xml file that are not
found in the properties file, e.g. as a result of a typo, etc.

 Wassim Melhem
                                                                            
                                                                            
 (Embedded image moved to file: pic24347.gif)  Wassim Melhem                
 Staff Software Developer, The Eclipse Project                              
 IBM Toronto Laboratory                                                     
 8200 Warden Ave, Markham, ON   L6G 1C7                                     
 Internal Mail: D1/R0Q/8200/MKM   PWA: 318                                  
 Phone: 905-413-2620 T/L: 969-2620 Fax: 905-413-4850                        
 Email: wassimm@xxxxxxxxxx                                                  
                                                                            




                                                                           
             Jeff                                                          
             McAffer/Ottawa/IB                                             
             M@IBMCA                                                    To 
             Sent by:                  "Eclipse platform release           
             platform-releng-d         engineering list."                  
             ev-bounces@eclips         <platform-releng-dev@xxxxxxxxxxx>   
             e.org                                                      cc 
                                                                           
                                                                   Subject 
             05/20/2005 10:53          Re: [platform-releng-dev]           
             AM                        Translatable Attributes in manifest 
                                       files                               
                                                                           
             Please respond to                                             
             "Eclipse platform                                             
                  release                                                  
                engineering                                                
                  list."                                                   
                                                                           
                                                                           





On a slightly different but related note, can we warn people when they have
keys in their plugin.properties that are not used in the
plugin.xml/manifest.mf/fragment.xml?  What I am really after here is
finding people who are using plugin.properties to NL their *code* rather
than just their plugin manifests.  The approach I just mentioned may not
work well everywhere because sometime a fragment host has keys that are
only used by the fragments but that case is pretty rare I believe.

For context, using the plugin.properties to NL your code causes us to load
the strings twice since the runtime caches the values used by the
plugin.xml.

Jeff


                                                                           
 Wassim                                                                    
 Melhem/Toronto/IBM@IBMCA                                                  
 Sent by:                                                               To 
 platform-releng-dev-bounces               "Eclipse platform release       
 @eclipse.org                              engineering list."              
                                           <platform-releng-dev@xxxxxxxxxx 
                                           g>                              
 05/20/2005 10:30 AM                                                    cc 
                                                                           
                                                                   Subject 
      Please respond to                    [platform-releng-dev]           
  "Eclipse platform release                Translatable Attributes in      
      engineering list."                   manifest files                  
                                                                           
                                                                           
                                                                           
                                                                           
                                                                           
                                                                           
                                                                           





There is no way for the chkpii tool to determine without a shadow of a
doubt which attributes in the plugin.xml are translatable and which are
not.

But PDE can, thanks to all teams marking their translatable attributes as
such in their extension point schemas.

If the build process starts ignoring plugin.xml files wholesale to avoid
bogus errors, then legitimate errors would go unnoticed.

Therefore, I recommend that teams set the PDE manifest builder flag for
'usage of non-externalized strings' to ERROR.

To do so, bring up the properties dialog of your project.  Go to the
Plug-in Manifest Compiler property page, and the flag in question is listed
last.

Wassim.

By the way, the inspiration for this email came from my observation that in
Nick's workspace, all untranslated attributes are marked as ERROR.
So I presume the Platform/UI team were the pioneers of this.






            Sonia
            Dimitrov/Ottawa/I
            BM@IBMCA                                                   To
            Sent by:                  "Eclipse platform release
            platform-releng-d         engineering list."
            ev-bounces@eclips         <platform-releng-dev@xxxxxxxxxxx>
            e.org                                                      cc

                                                                  Subject
            05/20/2005 10:05          Re: [platform-releng-dev]
            AM                        [eclipse-build]Build
                                      N20050520-0010    (Timestamp:
                                      200505200010):Automated       JUnit
            Please respond to         testing complete.       Test
            "Eclipse platform         failures/errors occurred.
                 release
               engineering
                 list."








This plugin.xml has been added to the ignored file list.

Sonia



Darin
Wright/Ottawa/IB
M@IBMCA                                                                To
Sent by:                           "Eclipse platform release engineering
platform-releng-                   list."
dev-bounces@ecli                   <platform-releng-dev@xxxxxxxxxxx>
pse.org                                                                cc

                                                                  Subject
05/20/2005 09:12                   Re: [platform-releng-dev]
AM                                 [eclipse-build]Build
                                   N20050520-0010        (Timestamp:
                                   200505200010):Automated        JUnit
 Please respond                    testing complete.        Test
       to                          failures/errors occurred.
    "Eclipse
    platform
     release
   engineering
     list."









The chkpii error in jdt.debug.ui should be ignored. The text is not
intended to be translated:

eclipse/plugins/org.eclipse.jdt.debug.ui_3.1.0_jar/
plugin.xml    XML-10      969   (W) XML tag attribute (qualifier) may
contain translatable text which cannot be translated.  Line: 2515


Darin




eclipse-releng@xxxxxxxxxxx
Sent by: platform-releng-dev-bounces@xxxxxxxxxxx
05/20/2005 06:10 AM
Please respond to
"Eclipse platform release engineering list."


To
platform-releng-dev@xxxxxxxxxxx
cc

Subject
[platform-releng-dev] [eclipse-build]Build N20050520-0010 (Timestamp:
200505200010):Automated JUnit testing complete. Test failures/errors
occurred.






Build N20050520-0010 (Timestamp: 200505200010):  Automated JUnit testing
is complete.  Test failures/errors occurred in the following:

org.eclipse.ant.tests.ui_linux.gtk
org.eclipse.releng.tests_linux.gtk
org.eclipse.releng.tests_winxp
org.eclipse.swt.tests_linux.gtk

HTTP Download:


http://download.eclipse.org/downloads/drops/N20050520-0010

FTP Download:

               user: anonymous
               password: (e-mail address or leave blank)
               server:  download.eclipse.org
               cd to directory:  N20050520-0010

               or

               ftp://download.eclipse.org/N20050520-0010
_______________________________________________
platform-releng-dev mailing list
platform-releng-dev@xxxxxxxxxxx
https://dev.eclipse.org/mailman/listinfo/platform-releng-dev


_______________________________________________
platform-releng-dev mailing list
platform-releng-dev@xxxxxxxxxxx
https://dev.eclipse.org/mailman/listinfo/platform-releng-dev
_______________________________________________
platform-releng-dev mailing list
platform-releng-dev@xxxxxxxxxxx
https://dev.eclipse.org/mailman/listinfo/platform-releng-dev


_______________________________________________
platform-releng-dev mailing list
platform-releng-dev@xxxxxxxxxxx
https://dev.eclipse.org/mailman/listinfo/platform-releng-dev
_______________________________________________
platform-releng-dev mailing list
platform-releng-dev@xxxxxxxxxxx
https://dev.eclipse.org/mailman/listinfo/platform-releng-dev

Attachment: pic24347.gif
Description: GIF image


Back to the top