Skip to main content

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index] [List Home]
Re: [platform-releng-dev] [eclipse-build]Build N20040220 (Timestamp: 200402200010):Compile errors in build




With the use of PDE's classpath container, people have not had the need to
import plug-ins into their workspace anymore.  That was the intention.
However, in this setup, there is the problem that the JARs from the
external plug-ins that are not directed referenced by your workspace
plug-ins are  no longer contained within the java search scope.
So when Jeff searched for references to his method, he got 0 matches,
because he's a core guy and all clients of this method are external and not
referenced by his plug-ins.

Since 2.1, PDE has provided a function that allows you to search JARs in
external plug-ins without having to import them into your workspace.
Go the Plug-ins View.  Right-click on the external plug-in of your choice,
and select 'Add to Java Search' from the context menu.

This is one of the less known PDE features.  In fact, I think only one
person uses it (namely John Arthorne :-).
So we'll leave Jeff's bug report open and we welcome feedback on how to
make this feature more prominent and how to enhance it, since it does have
its limitations.

https://bugs.eclipse.org/bugs/show_bug.cgi?id=52651

Wassim.



                                                                           
             Jeff                                                          
             McAffer/Ottawa/IB                                             
             M@IBMCA                                                    To 
             Sent by:                  platform-releng-dev@xxxxxxxxxxx     
             platform-releng-d                                          cc 
             ev-admin@eclipse.                                             
             org                                                   Subject 
                                       Re: [platform-releng-dev]           
                                       [eclipse-build]Build N20040220      
             02/20/2004 09:46          (Timestamp:  200402200010):Compile  
             AM                        errors in build                     
                                                                           
                                                                           
             Please respond to                                             
             platform-releng-d                                             
                    ev                                                     
                                                                           
                                                                           





My apologies for this confusion.  There has been some miscommunication and
I failed to check as widely as I should have when doing that change.

The change was to API that is brand new and was never really advertised.
Previously this function was provided by Platform.getLocation().  The
introduction of getInstanceLocation was a precursor to the changes that you
saw last night.  Unfortunatly, getLocation() was erroneously marked as
@deprecated and people were pointed to getInstanceLocation().

The model going forward is that Eclipse may be run in many different
physical configurations.  The user, instance and configuration areas may be
cascaded (layered) and at arbitrary URLs.  The new Location type reflects
these realities.  In practice, for IDE scenarios in the near/medium term,
people can assume that the instance location (aka workspace) is on the
filesystem and that the URL returned from getInstanceLocation().getURL() is
in fact a file: URL.

So, if you are comfortable with your plugin only working on filesystem
based workspaces (again, most IDE related plugins should be), you can use
Platform.getLocation().  This is old API that we will need to retain for
some time (I have removed the @deprecated tag).

Jeff




                                                                           
 Markus Keller                                                             
 <markus_keller@xxxxxx.                                                    
 com>                                                                   To 
 Sent by:                               platform-releng-dev@xxxxxxxxxxx    
 platform-releng-dev-ad                                                 cc 
 min@xxxxxxxxxxx                                                           
                                                                   Subject 
                                        Re: [platform-releng-dev]          
 02/20/2004 04:00 AM                    [eclipse-build]Build N20040220     
                                        (Timestamp:  200402200010):Compile 
                                        errors in build                    
    Please respond to                                                      
   platform-releng-dev                                                     
                                                                           
                                                                           
                                                                           
                                                                           
                                                                           





The compilation errors are due to a breaking API change in
org.eclipse.core.runtime.Platform:

Platform.getInstanceLocation() used to return an IPath, but now returns a
org.eclipse.osgi.service.datalocation.Location, which apparently doesn't
implement IPath.

Could core.runtime owners please tell us whether this change will persist
and if yes, how client code should be adapted?

Thanks,
Markus




eclipse-releng@xxxxxxxxxxx
Sent by: platform-releng-dev-admin@xxxxxxxxxxx
2004-02-20 06:51
Please respond to
platform-releng-dev@xxxxxxxxxxx


To
platform-releng-dev@xxxxxxxxxxx
cc

Subject
[platform-releng-dev] [eclipse-build]Build N20040220 (Timestamp:
200402200010):Compile errors in build






Build N20040220 (Timestamp: 200402200010):  Compile errors in build.  See
attached compile logs.
(See attached file:
/builds/N/src/N-N20040220-200402200010/compilelogs/plugins/org.eclipse.help.base_3.0.0
/helpbase.jar.bin.log)
(See attached file:
/builds/N/src/N-N20040220-200402200010/compilelogs/plugins/org.eclipse.jdt.ui_3.0.0
/jdt.jar.bin.log)
(See attached file:
/builds/N/src/N-N20040220-200402200010/compilelogs/plugins/org.eclipse.pde.core_3.0.0
/pdecore.jar.bin.log)

Attachment: /builds/N/src/N-N20040220-200402200010/compilelogs/plugins/org.eclipse .help.base_3.0.0/helpbase.jar.bin.log
Description: Binary data

Attachment: /builds/N/src/N-N20040220-200402200010/compilelogs/plugins/org.eclipse.jdt .ui_3.0.0/jdt.jar.bin.log
Description: Binary data

Attachment: /builds/N/src/N-N20040220-200402200010/compilelogs/plugins/org.eclipse.pde .core_3.0.0/pdecore.jar.bin.log
Description: Binary data


Back to the top