Re: [platform-help-dev] Create new mozilla window

[konradk@xxxxxxxxxx]

Thank you Tom.  The bug you encounter is a problem, but I think the
priorities when displaying help in a browser are:

1.  Successfully open help in a browser.
2.  Reuse the browser for reloading of help, for example when user clicks
on search results in the workbench, or selects one of the related links in
the F1 popup.  This prevents user from needing to close multiple browser
windows that all display help.
3.  Have a browser window dedicated to help.

Currently we do not have the code in place to ensure 3. when using Mozilla
and you encountered this.  However your fix breaks 2. and I would rather
not have new window pop up for users every time.

If you think 2. is not important, than using the 2.1 Eclipse builds, you
can change your browser in help preferences from "Mozilla adapter" to
"Custom browser", and specify mozilla as the program.  Using Mozilla 1.1,
each launch of mozilla executable causes new window to pop up - same what
your fix does.

Konrad Kolosowski


       From: Tom Tromey <tromey@xxxxxxxxxx>
       Date: 22 Nov 2002 14:42:39 -0700
       Delivered-to: platform-help-dev@xxxxxxxxxxx
       User-agent: Gnus/5.09 (Gnus v5.9.0) Emacs/21.2

 Right now help in Eclipse will reuse an existing Mozilla window.
 I find this confusing.  Usually I am using the Mozilla windows I have
 open, and remembering to make a new window before asking Eclipse for
 help is too roundabout.

 So, I wrote the appended patch.  This changes Eclipse to ask Mozilla
 to create a new window.

 I think this will also fix bugzilla 23750.

 Tom

 Index:
 src/org/eclipse/help/ui/internal/browser/linux/MozillaBrowserAdapter.java
 ===================================================================
 RCS file:
 /usr/cygnus/eclipse-cvsroot/org.eclipse.help.ui/src/org/eclipse/help/ui/internal/browser/linux/MozillaBrowserAdapter.java,v

 retrieving revision 1.3
 diff -u -r1.3 MozillaBrowserAdapter.java
 ---
 src/org/eclipse/help/ui/internal/browser/linux/MozillaBrowserAdapter.java
 21 Oct 2002 16:56:13 -0000 1.3
 +++
 src/org/eclipse/help/ui/internal/browser/linux/MozillaBrowserAdapter.java
 22 Nov 2002 21:32:57 -0000
 @@ -139,7 +139,7 @@
                                     waitForBrowser();
                                     if (exitRequested)
                                                 return;
 -                                   if (openBrowser("mozilla -remote
 openURL(" + url + ")") == 0)
 +                                   if (openBrowser("mozilla -remote
 openURL(" + url + ", new-window)") == 0)
                                                 return;
                                     if (exitRequested)
                                                 return;
 @@ -156,4 +156,4 @@
                                                 }
                         }
             }
 -}
 \ No newline at end of file
 +}