[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index] [List Home]
Re: [platform-dev] Possible mistake in documentation for PreferencePage?


Hi Daniel,

You're probably right, plus the javadoc comment for createContents() reads:


   
* This framework method must be implemented by concrete subclasses.

Can you log a bug against platform-ui for a proper look please?  We'll be doing a doc pass shortly as part of shipping 3.4.


Kevin





Daniel Felix Ferber <dfferber@xxxxxxxxxxxxxxxxxx>
Sent by: platform-dev-bounces@xxxxxxxxxxx

05/21/2008 12:25 PM

Please respond to
"Eclipse platform general developers list." <platform-dev@xxxxxxxxxxx>

To
platform-dev@xxxxxxxxxxx
cc
Subject
[platform-dev] Possible mistake in documentation for PreferencePage?





Hope this is the right place to ask about a statement in PreferencePage
documentation, that I suspect to be wrong.

I was reading Eclipse Platform documentation from:
http://help.eclipse.org/help33/topic/org.eclipse.platform.doc.isv/reference/api/org/eclipse/jface/preference/PreferencePage.html


That states that:
"Subclasses must implement the createControl framework method to supply
the page's main control."

My question:
Shouldn't id be "Subclasses must implement the _createContents_
framework method to supply the page's main control."?

Because createControl is inherited from DialogPage and implements
buttons and decoration. The method then calls the abstract
createContents that people use to fill out the preference page with SWT
controls.

Best regards,
Daniel Ferber

_______________________________________________
platform-dev mailing list
platform-dev@xxxxxxxxxxx
https://dev.eclipse.org/mailman/listinfo/platform-dev