Skip to main content

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index] [List Home]
Re: [platform-core-dev] Re: [eclipse-dev] change to config.ini syntax


track
        https://bugs.eclipse.org/bugs/show_bug.cgi?id=61484
if you are interested.

Jeff



Thomas Watson <tjwatson@xxxxxxxxxx>
Sent by: platform-core-dev-admin@xxxxxxxxxxx

05/07/2004 06:44 PM

Please respond to
platform-core-dev

To
platform-core-dev@xxxxxxxxxxx
cc
Subject
Re: [platform-core-dev] Re: [eclipse-dev] change to config.ini syntax






Actually there are more problems with this.  It looks like PDE also parses this file and needs to be updated accordingly.  Here is a stack trace I get.


java.lang.NumberFormatException: For input string: "2:start"

       at java.lang.NumberFormatException.forInputString(NumberFormatException.java:48)

       at java.lang.Integer.parseInt(Integer.java:477)

       at java.lang.Integer.<init>(Integer.java:609)

       at org.eclipse.pde.internal.ui.launcher.LauncherUtils.getAutoStartPlugins(LauncherUtils.java:283)

       at org.eclipse.pde.internal.ui.launcher.LauncherUtils.getPluginsToRun(LauncherUtils.java:212)

       at org.eclipse.pde.internal.ui.launcher.WorkbenchLaunchConfigurationDelegate.getProgramArguments(WorkbenchLaunchConfigurationDelegate.java:120)

       at org.eclipse.pde.internal.ui.launcher.WorkbenchLaunchConfigurationDelegate.createVMRunner(WorkbenchLaunchConfigurationDelegate.java:80)

       at org.eclipse.pde.internal.ui.launcher.WorkbenchLaunchConfigurationDelegate.launch(WorkbenchLaunchConfigurationDelegate.java:51)

       at org.eclipse.debug.internal.core.LaunchConfiguration.launch(LaunchConfiguration.java:569)

       at org.eclipse.debug.internal.core.LaunchConfiguration.launch(LaunchConfiguration.java:150)

       at org.eclipse.debug.internal.ui.DebugUIPlugin.buildAndLaunch(DebugUIPlugin.java:770)

       at org.eclipse.debug.internal.ui.DebugUIPlugin$6.run(DebugUIPlugin.java:932)

       at org.eclipse.core.internal.jobs.Worker.run(Worker.java:66)


Thomas Watson



Thomas Watson/Austin/IBM@IBMUS
Sent by: platform-core-dev-admin@xxxxxxxxxxx

05/07/2004 05:33 PM
Please respond to platform-core-dev

       
       To:        platform-core-dev@xxxxxxxxxxx

       cc:        

       Subject:        Re: [platform-core-dev] Re: [eclipse-dev] change to config.ini syntax





I just checked in a fix for that.


Thomas Watson


Rafael Chaves <Rafael_Chaves@xxxxxxxxxx>
Sent by: platform-core-dev-admin@xxxxxxxxxxx

05/07/2004 05:17 PM
Please respond to platform-core-dev

       
      To:        platform-core-dev@xxxxxxxxxxx

      cc:        

      Subject:        [platform-core-dev] Re: [eclipse-dev] change to config.ini syntax





Maybe related to this: I am getting the following excepiton when starting a runtime workbench (in the console, since it happens even before the log is available):


!ENTRY org.eclipse.osgi May 07, 2004 18:13:57.357

!MESSAGE Startup error

!STACK 1

java.lang.NumberFormatException: For input string: "2:start"

 at java.lang.NumberFormatException.forInputString(NumberFormatException.java:62)

 at java.lang.Integer.parseInt(Integer.java:457)

 at java.lang.Integer.parseInt(Integer.java:498)

 at org.eclipse.core.runtime.adaptor.EclipseStarter.loadBasicBundles(EclipseStarter.java:397)

 at org.eclipse.core.runtime.adaptor.EclipseStarter.startup(EclipseStarter.java:212)

 at org.eclipse.core.runtime.adaptor.EclipseStarter.run(EclipseStarter.java:118)

 at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)

 at sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:79)

 at sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:41)

 at java.lang.reflect.Method.invoke(Method.java:371)

 at org.eclipse.core.launcher.Main.basicRun(Main.java:269)

 at org.eclipse.core.launcher.Main.run(Main.java:700)

 at org.eclipse.core.launcher.Main.main(Main.java:684)




May 7, 2004 5:10 PM
To: eclipse-dev@xxxxxxxxxxx
cc:
From: Jeff McAffer/Ottawa/IBM@IBMCA
Subject: [eclipse-dev] change to config.ini syntax



To enable several RCP and non-Update scenarios we had to modify slightly the syntax used for the osgi.bundles line in config.ini.  If you don't now what either of these are, you can likely stop reading now as this only affects people who might be managing their own values for osgi.bundles.


Previously you could list a set of bundles to install and start using the syntax

osgi.bundles=org.eclipse.core.runtime@2, org.eclipse.update.configurator@3


In config.ini (actually using any technique for setting a System property).   This caused the listed plugins/bundles to be discovered, installed and started with the given (optional) startlevel.  Unfortunately there was no syntax for just installing a bundle without starting it.  Given that we want, as usual, the default to be lazy and not eagerly start plugins, the above syntax had to change.  


The new syntax which is equivalent to the above is

#osgi.bundles=org.eclipse.core.runtime@2:start, org.eclipse.update.configurator@3:start


Here the "start" attribute is optional.  If it is not there then the bundle is just installed.  It *may* be autostarted at a later time using the normla eclipse autoactivation logic but it will not be eagerly started.


So what does this mean to you.  Well, as mentioned above, nothing unless you actually know and care for an osgi.bundles setting somewhere.  Existing configurations have this setting but it is commented out (thus getting a default behaviour the runtime defines).  If you do maintain an osgi.bundles property then you will have to update its value when you try to run on the new code.  That code has been released to HEAD and will show up in the nightlies as well as the next integration build.

Jeff


Back to the top