[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index] [List Home]
[platform-compare-dev] Re: [platform-team-dev] Compare/Patch contribution


Thanks, I'll have a look. Unfortunately, I've done a bit a refactoring in some of those classes so the patch application may not be straight forward. I guess we can use this as a test case for the improved Apply Patch wizard we are working on ;-)

Michael



Michael Scharf <Michael-Scharf@xxxxxx>
Sent by: platform-team-dev-bounces@xxxxxxxxxxx

09/11/2006 10:33 AM

Please respond to
Generic team support framework <platform-team-dev@xxxxxxxxxxx>

To
Generic team support framework <platform-team-dev@xxxxxxxxxxx>
cc
Max Weninger <max.weninger@xxxxxxxxxxxxx>, platform-compare-dev@xxxxxxxxxxx
Subject
Re: [platform-team-dev] Compare/Patch contribution





Hi Michael,

Max has now submitted patches (based on 3.2!) for
[Edit] Undo in compare
  https://bugs.eclipse.org/bugs/show_bug.cgi?id=131895
[Viewers] Show line numbers in comparision
  https://bugs.eclipse.org/bugs/show_bug.cgi?id=72936

For the other patches we'll wait until after M2..


Michael

>
> We would be happy to accept your contributions to Compare. However, the
> Apply Patch wizard changes may be a bit too late as we have already
> started this ourselves and are nearing completion. The best course of
> action there would probably be to wait and see what we put into 3.3 M2
> and ensure that it meets you needs. I am curious to know how your
> solution handled hunks that could not be matched (i.e. the unmatched
> portions that get thrown into the .rej file)?
>
> As for the other two bugs, we would be happy to accept patches. Ideally,
> the patches should be split according to the bug addressed and attached
> to the bug report.
>
> Michael
>
>
>
> *Michael Scharf <Michael-Scharf@xxxxxx>*
> Sent by: platform-team-dev-bounces@xxxxxxxxxxx
>
> 09/11/2006 08:50 AM
> Please respond to
> Generic team support framework <platform-team-dev@xxxxxxxxxxx>
>
>
>                  
> To
>                  platform-team-dev@xxxxxxxxxxx
> cc
>                  max.weninger@xxxxxxxxxxxxx
> Subject
>                  [platform-team-dev] Compare/Patch contribution
>
>
>                  
>
>
>
>
>
> Hi,
>
> Max Weninger did some did some enhancements and bug fixes
> in the compare plugin specific to the needs of our product.
>
> Specifically for the "Apply Patch" wizard.
> But also in the compare plugin in general.
>
> Are you interessted in looking into these changes
> and possible use them as our contribution?
>
> The following bugzilla entries are relevant to
> these changes/fixes.
>
> [Patch] Apply Patch deosn't preview changes against workspace
>   https://bugs.eclipse.org/bugs/show_bug.cgi?id=40971
>
> [Edit] Undo in compare
>   https://bugs.eclipse.org/bugs/show_bug.cgi?id=131895
>
> "c compare viewer" should show line-numbers
>   https://bugs.eclipse.org/bugs/show_bug.cgi?id=126702
>
> It is a large set of changes but could be splitted
> in smaller pieces adressing specific bugzilla entries.
>
> We would like to contribute those changes to eclipse.
>
>
> Michael (on behalf of Max)
> --
> Michael Scharf
> Wind River Systems GmbH
> http://www.WindRiver.com
> http://MichaelScharf.blogspot.com/
>
>
> _______________________________________________
> platform-team-dev mailing list
> platform-team-dev@xxxxxxxxxxx
> https://dev.eclipse.org/mailman/listinfo/platform-team-dev
>
>
> ------------------------------------------------------------------------
>
> _______________________________________________
> platform-team-dev mailing list
> platform-team-dev@xxxxxxxxxxx
> https://dev.eclipse.org/mailman/listinfo/platform-team-dev


--
Michael Scharf
Wind River Systems GmbH
http://www.WindRiver.com
http://MichaelScharf.blogspot.com/

_______________________________________________
platform-team-dev mailing list
platform-team-dev@xxxxxxxxxxx
https://dev.eclipse.org/mailman/listinfo/platform-team-dev