[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index] [List Home]
Re: [pdt-dev] Introduce new PHP Server plugin

Hi ibazzi,

I feel you will become a great PDT contributor ;)

You made a lot of patches, it would be great to include them in our repository so everybody would benefit from your work ;)


The best way in my opinion is still to submit them through gerrit, so that we can review them quietly. First step would be (on your side) to priorize the most important patches you'd like to send us ;)

For real bugfixes (or new features) a bug report should be open + you should also add some unit tests to the patches you'll post on gerrit. It adds a bit work, but it will help us to understand your patches and also avoid regressions.


For a minor change, a "No bug" patch will be enough.


In all cases, don't worry, we'll make reviews and comments in gerrit to help you for your first contributions ;)


If necessary, you also have this little guide to start with : https://wiki.eclipse.org/PDT/Contributing


Thierry.



De : pdt-dev-bounces@xxxxxxxxxxx <pdt-dev-bounces@xxxxxxxxxxx> de la part de ibazzi <ibazzi@xxxxxx>
Envoyà : mardi 21 mars 2017 15:00
à : PDT Developers
Objet : Re: [pdt-dev] Introduce new PHP Server plugin
 
oh, sure, you are welcome.

Let's make it better.

BTW, this my pdt repository with serval enhancement(CA, syntax validator, quick fix, debug, php search, organize use statements, etc)
https://github.com/ibazzi/pdt
https://github.com/ibazzi/pdt/pulls?q=is%3Apr+is%3Aclosed
https://github.com/ibazzi/dltk.core

let's see which can be merged into PDT main repository.

------------------ Original ------------------
From:  "Michal Niewrzal";<michal.niewrzal@xxxxxxxxxxxxx>;
Date:  Tue, Mar 21, 2017 10:41 PM
To:  "pdt-dev@xxxxxxxxxxx"<pdt-dev@xxxxxxxxxxx>;
Subject:  [pdt-dev] Introduce new PHP Server plugin

Hi,


Yes, your plugin looks very interesting :) I was able to test it but to do this I had to make some hacks in your code. If you like I can open GitHub issue to describe main problems.


Regards,

MichaÅ NiewrzaÅ | ZEND STUDIO

Rogue Wave Software, Inc.

Accelerating Great Code

www.roguewave.com / michal.niewrzal@roguewave.com




Od: pdt-dev-bounces@xxxxxxxxxxx <pdt-dev-bounces@xxxxxxxxxxx> w imieniu uÅytkownika Kaloyan Raev <kaloyan.r@xxxxxxxx>
WysÅane: 21 marca 2017 15:27
Do: pdt-dev@xxxxxxxxxxx
Temat: Re: [pdt-dev] Introduce new PHP Server plugin
 
Hi,

This looks nice! It actually addresses an enhancement bug we have in PDT Bugzilla: https://bugs.eclipse.org/bugs/show_bug.cgi?id=440485

It would be great if you do extra mile and contribute your work to PDT. You can consult this page for a contribution guide: https://wiki.eclipse.org/PDT/Contributing

Your first goal would be to push a Gerrit patch with your work that we can review. Let us know if you face any troubles.

--
Kaloyan Raev | Zend Studio Team Lead
Rogue Wave Software, Inc.
Accelerating Great Code
M +359 887 648 663
www.roguewave.com / kaloyan.raev@xxxxxxxxxxxxx

On 03/21/2017 03:11 PM, ibazzi wrote:
Hi there,

I have implemented the wtp server adapter for PHP with php built-in server. See the attachment.

Now we can add and publish projects, and debug with php built-in server.

Here is the respository for the plugin, and also some changes in pdt(work in progress).


If you are instrested in it, please let me know.

Best regards


_______________________________________________
pdt-dev mailing list
pdt-dev@xxxxxxxxxxx
To change your delivery options, retrieve your password, or unsubscribe from this list, visit
https://dev.eclipse.org/mailman/listinfo/pdt-dev