[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [pdt-dev] Question about debug.daemon plugin.
- From: "Michael Spector" <spektom@xxxxxxxxx>
- Date: Tue, 6 Jan 2009 15:37:45 +0200
- Delivered-to: email@example.com
- Domainkey-signature: a=rsa-sha1; c=nofws; d=gmail.com; s=gamma; h=message-id:date:from:to:subject:in-reply-to:mime-version :content-type:content-transfer-encoding:content-disposition :references; b=RO/IEEOhQqrrW80MHsIQPBX2TErMQ0VnNNQZnB0ihAjQXUIRMARJoGpIVhFI78RYr+ O4xsrz0vsyoLSy9v1oiUdvWsqFpc3NDcR2fz+uqxR4f0332EcJwnPiPuSdAUdHETufhE nE3fSgBiWrDDP3Au4WnOpjCV9Lewv4tGJVGgM=
The only reason for that IIRC was eliminating the need to load the PHP
stuff (debug plug-in has a dependency with PHP core) on startup. I
don't understand why it's being done in PHPDebugPlugin instead of
DaemonPlugin, I think the listeners startup code can be moved there.
2009/1/6 Dave Kelsey <d_kelsey@xxxxxxxxxx>:
> I noticed a problem where the debug socket listeners were not being started
> in some cases when PDT was first started. It turns out that if you don't
> have a PHP file open or the PHP Debug perspective being listed as an opened
> perspective (not necessarily the active perspective) then the socket
> listeners are not started.
> Looking at the code I see that the debug.daemon (which contains the code to
> start the socket listeners) plugin registers an earlyStartup, but the
> starting of that plugin (earlyStartup() or start() ) actually doesn't do
> anything, so the earlyStartup is redundent. The code to start the listeners
> is actually found in the debug.core plugin in its start() method, which
> means that unless this plugin gets loaded the socket listeners won't start
> until it does get loaded and this can and does get delay loaded.
> The obvious answer to this would be that as the debug.daemon has an
> earlyStartup registered, that this should start the socket listeners, not
> the debug.core plugin and I would like to make this change. Does anyone know
> why the code did it this way or is there any good reason why it shouldn't be
> changed ? (An alternative would be to have the debug.core plugin register an
> earlyStartup and remove the one from the debug.daemon plugin).
> I would like to get this change into PDT 2.0.1 as well.
> Dave Kelsey
> Unless stated otherwise above:
> IBM United Kingdom Limited - Registered in England and Wales with number
> Registered office: PO Box 41, North Harbour, Portsmouth, Hampshire PO6 3AU
> pdt-dev mailing list