Skip to main content

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index] [List Home]
Re: [pdt-dev] resolving class variables

Michael,

It seems you're wrong - there were another problems there :). In general we should provide always the CURRENT file name when resolving elements. And the model attemts to correctly determine the elements according to the data (with or without model filter).

Thanks for pointing the issue(s).

On Tue, 6 Mar 2007 23:39:51 +0200 "Michael Spector" <spektom@xxxxxxxxx> wrote:

MS> I have a question regarding a commented line in CodeDataResolver:
MS> 
MS> //  String fileName = classDatas[i].isUserCode() ?
MS> classDatas[i].getUserData().getFileName() : "";
MS> result = ModelSupport.merge(result, toArray(
MS> projectModel.getClassVariablesData(fileData.getName(), className,
MS> elementName)));
MS> 
MS> I think, now it looks for class variables only in current file, and not in
MS> file where specific class where declared...
MS> Please tell me, that I'm wrong :)
MS> 
MS> Thanks!
MS> 
MS> BTW, there is a problem in FilterableCompositePhpModel (filter is null):
MS> 
MS> java.lang.NullPointerException
MS>         at
MS> org.eclipse.php.internal.core.phpModel.parser.FilterableCompositePhpModel.getFilteredClasses
MS> (FilterableCompositePhpModel.java:98)
MS>         at
MS> org.eclipse.php.internal.core.util.CodeDataResolver.getMatchingClasses(
MS> CodeDataResolver.java:259)
MS>         at org.eclipse.php.internal.core.util.CodeDataResolver.resolve(
MS> CodeDataResolver.java:197)
MS>         at org.eclipse.php.internal.core.util.CodeDataResolver.resolve(
MS> CodeDataResolver.java:77)
MS>         at
MS> org.eclipse.php.internal.ui.editor.hover.PHPSourceTextHover.getHoverInfo(
MS> PHPSourceTextHover.java:97)
MS>         at
MS> org.eclipse.php.internal.ui.editor.hover.BestMatchHover.getHoverInfo(
MS> BestMatchHover.java:99)
MS>         at
MS> org.eclipse.php.internal.ui.editor.hover.PHPTextHoverProxy.getHoverInfo(
MS> PHPTextHoverProxy.java:63)
MS> 
MS> -- 
MS> Michael

Seva Lapsha
[slapsha@xxxxxxxxxxxxxxx]
Zend Eclipse Developer



Back to the top