Re: [pde-dev] Controlling the pde build to change the content of bundles

[Andrew Niefer <aniefer@xxxxxxxxxx>]

Serge,
I don't know where to start without
some idea of how you're build is set up.  (The SDK releng build was
a horrible beast).

A 3.4 and higher Eclipse build should
be installed by the p2 director to be properly configured.  In this
case it will be p2 writing the bundles.info file.  The content will
depend on the metadata.

You will at some point need a .product
file, the SDK releng build ran a .product file through the packager to
get the metadata it needed.  A normal product build would be simpler.
The P2Utils code only gets called with
a .product file if a config.ini is not provided (also depending on what
bundles are included in the product).

I  believe the 3.4 metadata generator
did create metadata to set the reconciler to be started by default.  
Look at the call hierarchy of EclipseInstallGeneratorInfoProvider#createDropinsReconcilerBundleInfo()
in org.eclipse.equinox.p2.metadata.generator to see this.

-Andrew

From:	Serge Beauchamp <serge@xxxxxxxxxxxxx>
To:	pde-dev@xxxxxxxxxxx
Date:	08/07/2009 07:50 AM
Subject:	[pde-dev] Controlling the pde build to change the content of        bundles.info
Sent by:	pde-dev-bounces@xxxxxxxxxxx

---

Hello,

I've been working on producing a PDE build of the eclipse 3.4.1 sources
for some time, and although it mostly works, one that that still eludes
me is that the bundles.info file generated by the build process contains
the following line:

org.eclipse.equinox.p2.reconciler.dropins,1.0.2.R34x_v20080909,file:plugins/org.eclipse.equinox.p2.reconciler.dropins_1.0.2.R34x_v20080909.jar,4,false

instead of the following in an official Eclipse build:

org.eclipse.equinox.p2.reconciler.dropins,1.0.2.R34x_v20080909,file:plugins/org.eclipse.equinox.p2.reconciler.dropins_1.0.2.R34x_v20080909.jar,4,true

(noticed the "false" as the auto start flag instead of the "true").
 
This obviously cause adverse effects, since not having the 
p2.reconciler.dropins started automatically prevents all additional 
plugins to be started as well.

I've looked at changing the content of  writeBundlesTxt() in 
org.eclipse.pde.internal.core.P2Utils and 
org.eclipse.pde.internal.build.site.P2Utils so that there's a special 
case for the p2.reconciler.dropins plugins, as follows:

                if 
("org.eclipse.equinox.simpleconfigurator".equals(modelName))
{ //$NON-NLS-1$
                    bundleMap.put(desc,
"1:true"); //$NON-NLS-1$
// those 2 lines below added:
                } else if 
("org.eclipse.equinox.p2.reconciler.dropins".equals(modelName))
{ 
//$NON-NLS-1$
                    bundleMap.put(desc,
"4:true"); //$NON-NLS-1$
                } else if 
("org.eclipse.equinox.common".equals(modelName)) { //$NON-NLS-1$
                    bundleMap.put(desc,
"2:true"); //$NON-NLS-1$

But that code path doesn't even seems to be called. 

Does anyone has some leads about where should I investigate to be sure
that the p2.reconciler.dropins gets the proper "true" auto start
flag in 
the bundles.info file?

Thanks!

Serge Beauchamp
Software Engineer
Freescale Semiconductor
_______________________________________________
pde-dev mailing list
pde-dev@xxxxxxxxxxx
https://dev.eclipse.org/mailman/listinfo/pde-dev