Re: [pde-build-dev] JNLP, pack200, and nested jars

[Thomas Hallgren <thomas@xxxxxxx>]

Andrew Niefer wrote:
> Thomas,
> The pack.excludes should apply to nested jars.  Note that you need to 
> use the name of the nested jar as it appears in its containing jar. 
>  In the case of org.eclipse.core.resources, I think it would be
> pack.excludes=ant_tasks\resources-ant.jar
>
> If you are trying to debug it, the filtering is done at 
> PackStep.recursionEffect.
OK, I'll check that out. My patch works, but it's kind of ugly.

> If this doesn't work you can raise a bug.  The pack.excludes is not 
> very robust, the eclipse.inf is a better way to do things if they are 
> your jars.  But note that if you are patching signed jars, and you 
> modify the eclipse.inf, you will break verification of that jar.
No problem. I repack and sign them again.

Regards,
Thomas Hallgren

> -Andrew
>
>
>
> *Thomas Hallgren <thomas@xxxxxxx>*
> Sent by: pde-build-dev-bounces@xxxxxxxxxxx
>
> 05/16/2007 02:36 AM
> Please respond to
> "Eclipse PDE Build developers list." <pde-build-dev@xxxxxxxxxxx>
>
>
> 	
> To
> 	"Eclipse PDE Build developers list." <pde-build-dev@xxxxxxxxxxx>
> cc
> 	
> Subject
> 	Re: [pde-build-dev] JNLP, pack200, and nested jars
>
>
>
> 	
>
>
>
>
>
> Apparently the 'pack.excludes' property do not apply to nested jars. Is
> that per design or should I report a bugzilla on that?
>
> The only option left to me was to actually patch the eclipse.inf in the
> culprit bundle.
>
> - thomas
>
>
> Thomas Hallgren wrote:
> > Hi Andrew,
> > Does the pack.excludes property apply to jars within other jars? I
> > guess they do and that solves my problem although what I really would
> > like is the ability to set
> >
> > jarprocessor.exclude.children.pack = true
> >
> > in the pack.properties. I know that in my case (when generating for
> > JNLP), whenever I encounter a nested jar, it should refrain from
> > packing. It appears this property is never read from the
> > pack.properties. Would it be feasible to change this so that the
> > global properties from 'pack.properties' is added to the
> > 'containingInfs' list that the JarProcessor maintains?
> >
> > - thomas
> >
> >
> > Andrew Niefer wrote:
> >>
> >> The pack.properties file also supports a 'pack.excludes' property.
> >>  The value is a comma separated list of jar names to exclude.
> >>
> >> -Andrew
> >>
>
> _______________________________________________
> pde-build-dev mailing list
> pde-build-dev@xxxxxxxxxxx
> https://dev.eclipse.org/mailman/listinfo/pde-build-dev
>
> ------------------------------------------------------------------------
>
> _______________________________________________
> pde-build-dev mailing list
> pde-build-dev@xxxxxxxxxxx
> https://dev.eclipse.org/mailman/listinfo/pde-build-dev
>