Re: [paho-dev] Fix was not part of merge from develop?

[Ian Craggs <icraggs@xxxxxxxxxxxxxxxxxxxxxxx>]

Hi,

as far as I remember, I didn't add it in because I wasn't sure that this was the right approach.  The fix was rushed in, and I didn't want to be rushed into releasing it.  As the API is mature, we wouldn't be able to reverse this API change until a major release number update (to 2.0 for instance).

One alternative suggestion was that there should simply be no limit at all (except the MQTT imposed 65535), and so the connect options would not need the max inflight messages setting.

Now, I think I'm happy that this is the best option, so I could create a new service release with the change.

Ian

On 04/28/2015 11:43 AM, Mattias Isegran Bergander wrote:

 

Hi,

 

Looks to me like a commit for bug https://bugs.eclipse.org/bugs/show_bug.cgi?id=456855 to develop on Feb at 6:31 EST was not part of a merge on Feb 6 7:01 EST end result being that that fix is not part of java client lib 1.0.2.

 

Am I perhaps missing something?

 

Details:

Was this supposed to be part of the java client lib 1.0.2 (version 1.1)? It was merged 30min before the merge of develop to master if I read the time stamps correctly (but that merge does not contain this) so this fix is NOT part of that release.

For example, compare MqttConnectOptions.java in develop vs master:

http://git.eclipse.org/c/paho/org.eclipse.paho.mqtt.java.git/tree/org.eclipse.paho.client.mqttv3/src/main/java/org/eclipse/paho/client/mqttv3/MqttConnectOptions.java

Meaning this commit merge "Merge branch 'develop'":

http://git.eclipse.org/c/paho/org.eclipse.paho.mqtt.java.git/commit/?id=3f81520b8300ebe0bfcedfb497a2c69b0c72dddc

on Feb 6 at 7:01 EST did not contain this bug report's commit to develop at Feb 6 6:31 EST both by Ian:

http://git.eclipse.org/c/paho/org.eclipse.paho.mqtt.java.git/commit/?id=3f81520b8300ebe0bfcedfb497a2c69b0c72dddc

 

 

 

--

Mattias Isegran Bergander

 

_______________________________________________
paho-dev mailing list
paho-dev@xxxxxxxxxxx
To change your delivery options, retrieve your password, or unsubscribe from this list, visit
https://dev.eclipse.org/mailman/listinfo/paho-dev

-- 
Ian Craggs                          
icraggs@xxxxxxxxxx                 IBM United Kingdom
Paho Project Lead; Committer on Mosquitto