Skip to main content
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index] [List Home]
Re: [paho-dev] MQTT Interoperability Test Suite - Coverage 
Hi Ian,

Christoph reminded me I needed to take another look at these tests. I
spotted a small bug - you've got the password and username flag bit
positions transposed. This affects the case where only a username is
specified.

Cheers,

Roger


On Fri, Feb 6, 2015 at 12:49 AM, Ian Craggs
<icraggs@xxxxxxxxxxxxxxxxxxxxxxx> wrote:
> Christoph,
>
> ah, cool, that looks great!  I'll check it out tomorrow.
>
> Ian
>
>
> On 02/06/2015 12:46 AM, Christoph Krey wrote:
>
> Ian,
>
> changes are submitted in gerrit.
>
> with the changes I was able to get almost complete coverage:
>
> INFO 20150205 231508 exceptions 7 out of 22 = 31%
> INFO 20150205 231508 coverage statements 74 out of 80 = 92%
> INFO 20150205 231508 exceptions found {'[MQTT-2.3.1-1]', '[MQTT-3.8.3-1]',
> '[MQTT-4.7.1-3]', '[MQTT-3.1.2-22]', '[MQTT-4.7.1-2]', '[MQTT-4.7.3-3]',
> '[MQTT-3.3.2-2]'}
> INFO 20150205 231508 exceptions not found {'[MQTT-3.1.2-3]',
> '[MQTT-1.5.3-1]', '[MQTT-3.1.0-2]', '[MQTT-3-8.3-2]', '[MQTT-2.1.2-1]',
> '[MQTT-2.1.2-4]', '[MQTT-3.1.0-1]', '[MQTT-3.1.2-13]', '[MQTT-3.1.2-1]',
> '[MQTT-3.1.2-12]', '[MQTT-1.5.3-2]', '[MQTT-2.0.0-1]', '[MQTT-4.8.0-1]',
> '[MQTT-3.1.2-11]', '[MQTT-3.9.3-2]'}
> INFO 20150205 231508 coverage statements found {'[MQTT-3.1.2-6]',
> '[MQTT-3.1.2-9]', '[MQTT-3.1.4-2]', '[MQTT-4.7.3-1]', '[MQTT-3.1.2-4]',
> '[MQTT-3.10.4-1]', '[MQTT-3.8.4-5]', '[MQTT-3.1.2-17]', '[MQTT-3.1.2-18]',
> '[MQTT-4.7.3-2]', '[MQTT-2.3.1-5]', '[MQTT-3-10.1-1]', '[MQTT-3.1.2-19]',
> '[MQTT-3.2.2-5]', '[MQTT-3.5.4-1]', '[MQTT-3.1.3-7]', '[MQTT-3.1.3-3]',
> '[MQTT-3.8.4-4]', '[MQTT-3.1.3-6]', '[MQTT-2.3.1-4]', '[MQTT-3.10.4-5]',
> '[MQTT-3.1.4-1]', '[MQTT-3.1.3-9]', '[MQTT-3.10.4-6]', '[MQTT-2.1.2-9]',
> '[MQTT-3.1.3-1]', '[MQTT-4.4.0-2]', '[MQTT-4.3.3-2]', '[MQTT-3.1.2-7]',
> '[MQTT-2.1.2-6]', '[MQTT-3.1.2-21]', '[MQTT-3.14.4-3]', '[MQTT-3.3.1-2]',
> '[MQTT-2.1.2-7]', '[MQTT-2.3.1-1]', '[MQTT-3.9.3-1]', '[MQTT-3.10.4-2]',
> '[MQTT-3.1.3-4]', '[MQTT-3.12.4-1]', '[MQTT-3.1.3-5]', '[MQTT-3.1.2-10]',
> '[MQTT-3.1.2-22]', '[MQTT-3.2.0-1]', '[MQTT-3.1.2-2]', '[MQTT-3.1.2-16]',
> '[MQTT-3.1.3-2]', '[MQTT-3.14.4-2]', '[MQTT-4.7.3-3]', '[MQTT-4.3.3-1]',
> '[MQTT-3.6.1-1]', '[MQTT-3.8.4-3]', '[MQTT-3.1.4-5]',
> '[MQTT-1.5.3-3]', '[MQTT-4.3.2-1]', '[MQTT-3.1.2-20]', '[MQTT-3.3.1-11]',
> '[MQTT-1.1.0-1]', '[MQTT-2.1.2-12]', '[MQTT-4.7.1-3]', '[MQTT-3.3.5-1]',
> '[MQTT-3.1.2-8]', '[MQTT-3.10.4-4]', '[MQTT-3.1.2-5]', '[MQTT-2.1.2-10]',
> '[MQTT-4.1.0-1]', '[MQTT-3.2.3-3]', '[MQTT-4.6.0-6]', '[MQTT-4.7.1-2]',
> '[MQTT-4.4.0-1]', '[MQTT-2.3.1-7]', '[MQTT-3.8.4-1]', '[MQTT-2.1.2-3]',
> '[MQTT-3.1.3-8]', '[MQTT-2.3.1-6]'}
> INFO 20150205 231508 coverage statements not found {'[MQTT-3.10.4-3]',
> '[MQTT-4.3.2-3]', '[MQTT-3.3.1-3]', '[MQTT-3.14.1-1]', '[MQTT-3.3.2-1]',
> '[MQTT-4.3.2-2]'}
>
>
>
> Thanks
>    Christoph
>
>
> Am 05.02.2015 um 17:21 schrieb Ian Craggs <icraggs@xxxxxxxxxxxxxxxxxxxxxxx>:
>
> Christoph,
>
> please raise bugs, or submit changes with gerrit.  The about file has
> pointers to the Eclipse documentation for contributing:
>
> http://git.eclipse.org/c/paho/org.eclipse.paho.mqtt.c.git/about/
>
> (If you are interested in becoming a committer for Paho, then a good place
> to start is here:
>
> https://eclipse.org/membership/become_a_member/committer.php.  Usually for
> contributions, gerrit is the way to go).
>
> Thanks.
>
> Ian
>
>
> On 02/05/2015 02:51 PM, Christoph Krey wrote:
>
> Ian,
>
> you are correct.  I thought I'd updated the broker conformance statement
> numbers to match the final version of the MQTT standard, but it looks like I
> have some work to do there.
>
> there are a few other similar issues.
> Would you like me to log bugs, create a pull request for you, or shall I
> apply to become a committer to your repo?
>
> Christoph
>
>
>
> _______________________________________________
> paho-dev mailing list
> paho-dev@xxxxxxxxxxx
> To change your delivery options, retrieve your password, or unsubscribe from
> this list, visit
> https://dev.eclipse.org/mailman/listinfo/paho-dev
>
>
> --
> Ian Craggs
> icraggs@xxxxxxxxxx                 IBM United Kingdom
> Paho Project Lead; Committer on Mosquitto
>
> _______________________________________________
> paho-dev mailing list
> paho-dev@xxxxxxxxxxx
> To change your delivery options, retrieve your password, or unsubscribe from
> this list, visit
> https://dev.eclipse.org/mailman/listinfo/paho-dev
>
>
>
>
> _______________________________________________
> paho-dev mailing list
> paho-dev@xxxxxxxxxxx
> To change your delivery options, retrieve your password, or unsubscribe from
> this list, visit
> https://dev.eclipse.org/mailman/listinfo/paho-dev
>
>
> --
> Ian Craggs
> icraggs@xxxxxxxxxx                 IBM United Kingdom
> Paho Project Lead; Committer on Mosquitto
>
>
> _______________________________________________
> paho-dev mailing list
> paho-dev@xxxxxxxxxxx
> To change your delivery options, retrieve your password, or unsubscribe from
> this list, visit
> https://dev.eclipse.org/mailman/listinfo/paho-dev

Back to the top