Re: [p2-dev] Problems with boostrap installs, mysterious missing jars, a

[ali_anwar <ali_anwar@xxxxxxxxxxxxxxxx>]

On 01/01/2013 09:12 PM, ali_anwar wrote:
> On 01/01/2013 06:41 PM, ali_anwar wrote:
> > On 12/28/2012 12:44 PM, ali_anwar wrote:
> > > I have debugged the reported scenario. Following is my finding:
> > >
> > > 1. The IU is not downloaded as CollectAction > collect( ) function
> > > reported that aggregatedRepositoryView.contains(key), so
> > > ArtifactRepositoryManager.NO_ARTIFACT_REQUEST was returned.
> >
> > Further debugging revealed that the issue is reproducible only when the
> > aggregatedBundleRepository is fetched from the "result =
> > basicGetRepository(location);". Following is the debug stack:
> >
> > ArtifactRepositoryManager(AbstractRepositoryManager).loadRepository(URI,
> > IProgressMonitor, String, int) line: 634
> > ArtifactRepositoryManager.loadRepository(URI, int, IProgressMonitor)
> > line: 104
> > ArtifactRepositoryManager.loadRepository(URI, IProgressMonitor) line: 100
> > Util.getAggregatedBundleRepository(IProvisioningAgent, IProfile, int)
> > line: 135
> > Util.getAggregatedBundleRepository(IProvisioningAgent, IProfile) line: 96
> > CollectAction.collect(IProvisioningAgent, IProfile, IInstallableUnit)
> > line: 74
> > CollectAction.execute(Map) line: 33
> > Collect(Phase).mainPerform(MultiStatus, EngineSession, Operand[],
> > SubMonitor) line: 174
> > Collect(Phase).perform(MultiStatus, EngineSession, Operand[],
> > IProgressMonitor) line: 92
> > PhaseSet.perform(EngineSession, Operand[], IProgressMonitor) line: 47
> > Engine.perform(IProfile, IPhaseSet, Operand[], ProvisioningContext,
> > IProgressMonitor) line: 75
> > Engine.perform(IProvisioningPlan, IPhaseSet, IProgressMonitor) line: 44
> > [snip]
> >
> >
> > I think that while getting the repository the p2-director is not
> > updating the repository info whereas the repository has changed.
>
> When the repository is fetched from the basicGetRepository(location),
> the repository's state is being displayed as initialized. That is why
> "artifactRepository" was not reloaded.
>
> So the question is why sometimes the repository is fetched via
> basicGetRepository(location) and why not?

Hi guys, What are the consequences if have following change?

--- 
org.eclipse.equinox.p2.repository/src/org/eclipse/equinox/internal/p2/repository/helpers/AbstractRepositoryManager_old.java 
2013-01-04 01:36:56.646337484 +0500
+++ 
org.eclipse.equinox.p2.repository/src/org/eclipse/equinox/internal/p2/repository/helpers/AbstractRepositoryManager_new.java 
2013-01-04 01:36:31.246338145 +0500
@@ -629,9 +629,9 @@

 		try {
 			enterLoad(location, sub.newChild(5));
-			result = basicGetRepository(location);
-			if (result != null)
-				return result;
+			//result = basicGetRepository(location);
+			//if (result != null)
+			//	return result;
 			if (checkNotFound(location))
 				fail(location, ProvisionException.REPOSITORY_NOT_FOUND);

It seems to fix the issue but I am not sure about the approach.

Thanks,
-Ali