[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index] [List Home]
Re: [p2-dev] Improving shared installations - questions

On Tue, 2012-12-18 at 15:30 +0000, Pascal Rapicault wrote:
> I've pushed my changes to a branch named prapicau/sharedInstall-part1 in both the p2 and the equinox repo, respectively found at http://git.eclipse.org/c/equinox/rt.equinox.p2.git/log/?h=prapicau/sharedInstall-part1 and http://git.eclipse.org/c/equinox/rt.equinox.framework.git/log/?h=prapicau/sharedInstall-part1

Hey Pascal,

I have looked at your changes - and I like them in general (I had pretty
similar patch in Fedora for quite some time). 

My comments:

If you look at
org.eclipse.equinox.internal.simpleconfigurator.SimpleConfiguratorImpl.getConfigurationURL(),
you'll find that OSGi is capable of ignoring user configuration (which
will be rewritten later). This is the first place where such a
calculation is made, and  I believe it should be the only decisive
place. If nothing has changed, we use user configuration. If shared
configuration is newer than user one - use the shared one. Unfortunately
current implementation is weak - so I have opened 397216: [Shared]
Better shared configuration change discovery [1]. We could also include
things like config.ini into calculations here.

Once we know that we dropped user configuration, we set up a property,
upon which P2 must react only once - drop user profile. We should be OK
at this point. I have not opened bugs for this point yet.

Then it is "only" the matter of discovering bundles that had been
dropped.

[1] 397216: [Shared] Better shared configuration change discovery
https://bugs.eclipse.org/bugs/show_bug.cgi?id=397216