[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index] [List Home]
Re: [p2-dev] JUnit4 in org.eclipse.equinox.p2.tests?

To close the loop on this. This has been fixed: https://bugs.eclipse.org/bugs/show_bug.cgi?id=360797
Thx Tobias.

On 2011-10-13, at 9:04 AM, Daniel Le Berre wrote:

> Pros: It is much easier to write tests in Junit4 once you are used to features such as expected exceptions, timeout, @BeforeClass, etc.
> 
> Cons: it is a possible releng issue to have the code of the application and the tests compiled for a different target (jsr14 and 1.5).
> 
> I have to do that with Sat4j because all my old tests are in JUnit 3 and the most recent ones in JUnit 4.
> 
> Daniel
> 
> Le 13 oct. 2011 à 14:35, Pascal Rapicault a écrit :
> 
>> Pros and cons?
>> 
>> On 2011-10-13, at 7:39 AM, Oberlies, Tobias wrote:
>> 
>>> As far as I am aware, it would be very easy to allow JUnit4 Tests in org.eclipse.equinox.p2.tests (see https://bugs.eclipse.org/bugs/show_bug.cgi?id=360797 ).
>>> 
>>> Does anyone know a reason not to do this?
>>> 
>>> The change would be to really small and limited to org.eclipse.equinox.p2.tests:
>>> - require org.junit 4.8 or later (instead of 3.8 or later)
>>> - change the javacTarget to 1.5 (from jsr14)
>>> 
>>> Regards
>>> Tobias
>>> 
>>> 
>>> _______________________________________________
>>> p2-dev mailing list
>>> p2-dev@xxxxxxxxxxx
>>> https://dev.eclipse.org/mailman/listinfo/p2-dev
>> 
>> _______________________________________________
>> p2-dev mailing list
>> p2-dev@xxxxxxxxxxx
>> https://dev.eclipse.org/mailman/listinfo/p2-dev
> 
> --
>          Daniel Le Berre     mailto:leberre@xxxxxxx
>          MCF-HDR, CRIL-CNRS UMR 8188 Universite d'Artois
>          http://www.cril.univ-artois.fr/~leberre
> 
> _______________________________________________
> p2-dev mailing list
> p2-dev@xxxxxxxxxxx
> https://dev.eclipse.org/mailman/listinfo/p2-dev