[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [p2-dev] Buckminster builds completely broke when moving from M6 to RC1
- From: Pascal Rapicault <pascal@xxxxxxxxxxxx>
- Date: Sat, 14 May 2011 14:38:57 -0400
- Delivered-to: firstname.lastname@example.org
Sorry for the late breakage. This work was underway since the end of 2010 and only came to fruition right around EclipseCon. After having met with Tobias at EC, we decided to merge the code back into HEAD but the time to become comfortable with the changes, the time to do the merge (the work was done in the incubator) and toy around with the build, it was deemed too late to add it to M6 which explains why it has been released in M7.
Rest assure that the rules have not changed, but I definitely got better at convincing others :p
Note that even though the packages were in the API namespace, they were marked internal in the manifest. I know this is not very consistent with the rest of p2, but this was an experiment that we had decided to try a couple years back (when the publisher got introduced) to minimize the impact when an API is actually released in its final form (ppl would not have to rename their packages).
The new bundle is called org.eclipse.equinox.p2.publisher.eclipse and you will want to use the recent RC1 as a couple classes got changed this week.
On 2011-05-14, at 5:12 AM, Thomas Hallgren wrote:
> I found the packages. Apparently they moved to a pde bundle. After that, only three problem remained:
> 1. The FeatureManifestParser parse() method apparently changed signature. It now takes an additional URL argument. This is an internal class so I guess that kind of change is OK even after M6.
> 2. The AdviceFileAdvice moved from package o.e.e.p2.publisher.eclipse to o.e.e.p2.publisher. The packages are not internal.
> 3. I had to introduce a dependency to a new bundle in order to build, o.e.e.p2.publisher.eclipse.
> I found the magnitude of those post M6 changes somewhat surprising given what I perceived last year as very strict rules. The changes were easy to accommodate but it makes me wonder why we for instance had to keep the completely empty query bundle around. Did the rules change?
> Thomas Hallgren
> On 2011-05-14 09:27, Thomas Hallgren wrote:
>> Our builds are completely broken. Things that built just fine in 3.7M6 no longer builds. The reason seems to be that the org.eclipse.equinox.p2.publisher.eclipse package and it's internal counter part can no longer be found.
>> So, where did they go?
>> Thomas Hallgren
>> p2-dev mailing list
> p2-dev mailing list