Re: [p2-dev] SAP Contribution

[Jeff McAffer <jeff@xxxxxxxxxxxxxxxxx>]

Overall this is a great direction.

> At Eclipse Summit Pascal mentioned that replacing extension points with services for example could lead to unexpected side effects. 
> So before contributing back changes like this one, I would like  to discuss them in the mailing list - is there a better solution, do they fit into p2 architecture, etc. 

Ideally we would move to more of a dependency injection technique so p2 is not coupled to services or extensions.  For example, in the Toast example (http://wiki.eclipse.org/Toast) for the OSGi book (http://equinoxosgi.org) we used a interface that provides the things needed.  We provided service backed and extension backed implementations.  Much nicer.

Jeff