[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index] [List Home]
Re: [p2-dev] Removing MatchQuery in M7.

-1

We are past the API freeze and this is an enhancement rather than fixing an actual problem.  API freeze means that people can rely on the M6 API and not be fussed with things changing under them. If there was an actual functional issue then sure we can look at it. This is not a discussion around the new API being better and as I understand it, all benefits listed are still there without the removal of this API. The problem being addressed (e.g. the real benefit) is "the system is cleaner". There is a  lot of value in that before the API freeze.  We can mark it as deprecated etc (I know, looks funny) but removing it is disruptive.

Jeff

On 2010-03-31, at 11:19 AM, Thomas Hallgren wrote:

> As stated in the deprecation note for MatchQuery, we would like to get rid of this class for M7. We are also very anxious not to disrupt our clients.
> 
> Risks:
> 
> Clients may depend on the deprecated class. An alternative solution is included in the deprecation note but some code still need to be moved.
> 
> Benefits:
> 
> 1. Tests show that performance is at least a 100 times better when indexes are used. A MatchQuery can never use an index.
> 2. We don't risk queries that have side-effects during evaluation.
> 3. The expression evaluator can be cleaner if concerns about MatchQuery are removed.
> 4. API is cleaner and easier to elaborate.
> 5. Queries can be executed by a service in another process (database, remote, etc.)
> 6. No need to expose API for, or document, internal query behavior.
> 
> Regards,
> Thomas Hallgren
> 
> _______________________________________________
> p2-dev mailing list
> p2-dev@xxxxxxxxxxx
> https://dev.eclipse.org/mailman/listinfo/p2-dev