[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[p2-dev] Match/Context naming
- From: Thomas Hallgren <thomas@xxxxxxx>
- Date: Tue, 23 Feb 2010 19:08:47 +0100
- Delivered-to: firstname.lastname@example.org
- User-agent: Mozilla/5.0 (X11; U; Linux x86_64; en-US; rv:220.127.116.11) Gecko/20100120 Fedora/3.0.1-1.fc12 Lightning/1.0b1 Thunderbird/3.0.1
Before I did the latest refactoring, the expression equivalent for a
context query was named QLContextQuery and resided in the QL package.
For various reasons, I had to move that to the metadata package instead.
I then renamed it ExpressionContextQuery. So now we have ExpressionQuery
and ExpressionContextQuery. The former implements IMatchQuery and thus
expects a boolean expression to be applied on each row. The latter is a
full query that is applied on all rows.
I'm not at all happy with the names. Both queries are expression
queries. And the term 'context' strikes me as a bit odd. What context?
The evaluation context? Query context?
The term 'match' is better. The each candidate is matched against a
boolean expression. But I would really like two terms that are related.
'match' and 'context' has no relationship. How about 'each' and 'all' ? I.e.
ExpressionQuery (common super)
Do you have suggestions? I'd like to hear them.