[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index] [List Home]
Re: [p2-dev] FeaturesAction and absolute root files


The package is not exported because it is not part of the bundle proper, the library that contains them (lib/pdebuild-ant.jar) is not on the Bundle-ClassPath.
This is because ant tasks are kept separate from the bundle because of class loader issues (http://help.eclipse.org/ganymede/index.jsp?topic=/org.eclipse.platform.doc.isv/guide/ant_contributing_task.htm).

The root properties in particular make heavy use of ant classes.

To reuse them I see two options
1) do like export, generate a snippet of ant script and then run it (See pde.core's FeatureExportOperation#runScript
2) Get an Ant classloader and use reflection.  See org.eclipse.ant.core AntCorePlugin#getNewClassLoader().  AntRunner#run is an example of setting up the class loader.

-Andrew


Thomas Hallgren <thomas@xxxxxxx>
Sent by: p2-dev-bounces@xxxxxxxxxxx

06/02/2009 02:56 AM

Please respond to
P2 developer discussions <p2-dev@xxxxxxxxxxx>

To
P2 developer discussions <p2-dev@xxxxxxxxxxx>
cc
Subject
Re: [p2-dev] FeaturesAction and absolute root files





I would very much like to reuse the PDE-build 'publisher' classes in Buckminster. However, the org.eclipse.pde.internal.build.publisher package is not exported. Is that intended or just an oversight? All other packages are exported. Even the 'internal' ones.

Regards,
Thomas Hallgren

Andrew Niefer wrote:


>
Perhaps P2 should deal with binary publishing only and not consider the build.properties file at all.

I agree with this, it would also require the dropins support to not be calling the publisher on features/bundles that aren't binary (ie contain a build.properties files).


-Andrew

_______________________________________________
p2-dev mailing list
p2-dev@xxxxxxxxxxx
https://dev.eclipse.org/mailman/listinfo/p2-dev