Re: [p2-dev] FeaturesAction and absolute root files

[Andrew Niefer <aniefer@xxxxxxxxxx>]

> Perhaps P2
should deal with binary publishing only and not consider the build.properties
file at all.

I agree with this, it would also require
the dropins support to not be calling the publisher on features/bundles
that aren't binary (ie contain a build.properties files).

-Andrew

Thomas Hallgren <thomas@xxxxxxx>
Sent by: p2-dev-bounces@xxxxxxxxxxx

06/01/2009 10:51 AM

Please respond to
P2 developer discussions <p2-dev@xxxxxxxxxxx>

To	P2 developer discussions <p2-dev@xxxxxxxxxxx>
cc
Subject	Re: [p2-dev] FeaturesAction and absolute root files

Thanks for the clarification Andrew.

>From a puristic point of view, one might ask the question, why does
the P2 publisher provide any support at all for root files that are defined
in a build.properties file that probably shouldn't be included in the binary
in the first place? I think this needs to be discussed. We need a cleaner
separation of concern between PDE build and P2 in this respect. It's rather
confusing as it stands today.

Perhaps P2 should deal with binary publishing only and not consider the
build.properties file at all.

Regards,
Thomas Hallgren


Andrew Niefer wrote: 

Publisher support for root properties is incomplete and only works in the
most basic cases.   
The code there seems to be missing support for: 
- ant wildcard patterns 
- absolute: and file: prefixes 
- root.folder properties 
Also it may generate chmod instructions for files that don't exist, resulting
in failures at install time. 

See https://bugs.eclipse.org/bugs/show_bug.cgi?id=278086

The proper support for these properties is provided by PDE/Build.  
See the <eclipse.gatherFeature/>
ant task and GatherFeatureTask#createRootAdvice 

-Andrew

Thomas Hallgren <thomas@xxxxxxx>
Sent by: p2-dev-bounces@xxxxxxxxxxx

06/01/2009 02:49 AM

Please respond to
P2 developer discussions <p2-dev@xxxxxxxxxxx>

To	P2 developer discussions <p2-dev@xxxxxxxxxxx>
cc
Subject	[p2-dev] FeaturesAction and absolute root files

A Buckminster user has problems making the root files working. 
Apparently he is using the 'absolute:' prefix described in the 
documentation:

http://dev.eclipse.org/viewcvs/index.cgi/pde/doc/org.eclipse.pde.doc.user/tasks/pde_rootfiles.htm?view=co

I cannot find any support for that in the publisher. Has the support for
that being dropped or am I looking in the wrong place?

Regards,
Thomas Hallgren
_______________________________________________
p2-dev mailing list
p2-dev@xxxxxxxxxxx
https://dev.eclipse.org/mailman/listinfo/p2-dev

---

_______________________________________________
p2-dev mailing list
p2-dev@xxxxxxxxxxx
https://dev.eclipse.org/mailman/listinfo/p2-dev
  
_______________________________________________
p2-dev mailing list
p2-dev@xxxxxxxxxxx
https://dev.eclipse.org/mailman/listinfo/p2-dev