[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index] [List Home]
RE: [p2-dev] root files

<sigh>  I just figured that out after looking at the generated build.xml files in both cases.  I added p2.inf to my bin.includes and things happened as I expected.  I'll file a bug...
 
 
 
SERENITY NOW!
 
 
 
 
(Thanks, Andrew...)
 


From: p2-dev-bounces@xxxxxxxxxxx [mailto:p2-dev-bounces@xxxxxxxxxxx] On Behalf Of Andrew Niefer
Sent: May 25, 2009 5:22 PM
To: P2 developer discussions
Subject: RE: [p2-dev] root files


Can you raise a bug for this Mark.
customBuildCallbacks causes a different pattern in the generated ant because the user can do arbitrary stuff there.  We must stage the contents of the feature to some directory.
The publisher is likely never seeing your p2.inf file in this case.
Workaround would be to include the p2.inf in the final feature.jar by adding it to bin.includes.

-Andrew


"Mark Melvin" <Mark.Melvin@xxxxxxxxxx>
Sent by: p2-dev-bounces@xxxxxxxxxxx

05/25/2009 05:09 PM

Please respond to
P2 developer discussions <p2-dev@xxxxxxxxxxx>

To
"P2 developer discussions" <p2-dev@xxxxxxxxxxx>
cc
Subject
RE: [p2-dev] root files





OK, now here is the completely screwed-up part.  I have a
build.properties that looks like this:

 root = root_files
 bin.includes = feature.xml
 customBuildCallbacks = buildfiles/updateDependencies.xml
 customBuildCallbacks.failonerror = true
 customBuildCallbacks.inheritall = true

I am trying to contribute an IUFragment using the simple example Simon
sent awhile back.  It will not generate the fragment no matter what I
try.  But if I remove the three lines at the end of my build.properties
file that wire up my custom build hooks, it works and generates the
fragment!  WTF!?

I'm assuming this is a bug?  Or is there some Ant+PDE black magic I am
missing here?

Mark.
--------------------------------------------

> -----Original Message-----
> From: p2-dev-bounces@xxxxxxxxxxx
> [mailto:p2-dev-bounces@xxxxxxxxxxx] On Behalf Of Mark Melvin
> Sent: May 25, 2009 4:07 PM
> To: P2 developer discussions
> Subject: RE: [p2-dev] root files
>
> I'd be interested in an answer to this as well.  I have an
> existing feature that provides a full feature installation
> (so a <featurename>.jar IU), and I am attempting to add root
> files to it in addition to the normal JAR IU.  This seems to
> work and generates a proper, default IU for my root files,
> but if I attempt to override or contribute any fragments I
> get the maddening behaviour of the PDE export operation just
> ignoring my p2.inf content with no explanation.
>
> Is there a way I can debug this process to see exactly what it is that
> P2 doesn't like about my .inf file?  It really is starting to
> look like black magic.  Every time it looks like I have it
> figured out, I make one small tweak and everything just stops
> working and reverts all my metadata to default values.
>
> Mark.
> --------------------------------------------
>
> > -----Original Message-----
> > From: p2-dev-bounces@xxxxxxxxxxx
> > [mailto:p2-dev-bounces@xxxxxxxxxxx] On Behalf Of Haigermoser, Helmut
> > Sent: May 25, 2009 10:20 AM
> > To: P2 developer discussions
> > Subject: RE: [p2-dev] root files
> >
> > guys, this issue (if it is one) could be critical, can you confirm
> > root files are still working in 3.5, and if so, how?
> > TIA,
> > Ciao, hh
> >
> > -----Original Message-----
> > From: p2-dev-bounces@xxxxxxxxxxx
> > [mailto:p2-dev-bounces@xxxxxxxxxxx] On Behalf Of Haigermoser, Helmut
> > Sent: Wednesday, May 20, 2009 3:46 PM
> > To: P2 developer discussions
> > Subject: [p2-dev] root files
> >
> > Ciao Experts :)
> > Something seems to have changed since 3.4.1 concerning root
> files and
> > how to get them into a repository.
> > In my 3.4-based build I had a feature, included by
> > featureList=<feature>, and within that feature I had a line
> > root<config>=root.files
> >
> > This way all files in root.files ended up in the root of my
> > installation if I installed the product. Now, this does not seem to
> > work anymore.
> > Instead of adding the root files to the launcher binary artifact
> > separate feature IUs get generated, which is the first
> problem since
> > the feature's only purpose is to provide root files, not to
> end up at
> > the customer site. Also, that IU is never referenced by my
> product and
> > the root file never gets installed :(
> >
> > With pdebuild now doing the whole metadatageneration right
> at the time
> > the build is happening the whole system is different. Also, I might
> > have missed messages/bugs/blogs/twitters that dealt with
> this problem,
> > would you mind enlightening me? :)
> >
> > TIA,
> > Ciao, hh
> > _______________________________________________
> > p2-dev mailing list
> > p2-dev@xxxxxxxxxxx
> > https://dev.eclipse.org/mailman/listinfo/p2-dev
> > _______________________________________________
> > p2-dev mailing list
> > p2-dev@xxxxxxxxxxx
> > https://dev.eclipse.org/mailman/listinfo/p2-dev
> >
> _______________________________________________
> p2-dev mailing list
> p2-dev@xxxxxxxxxxx
> https://dev.eclipse.org/mailman/listinfo/p2-dev
>
_______________________________________________
p2-dev mailing list
p2-dev@xxxxxxxxxxx
https://dev.eclipse.org/mailman/listinfo/p2-dev