Re: [p2-dev] WizardWithLicenses enables finish before accepting license

[Susan Franklin McCourt <susan_franklin@xxxxxxxxxx>]

can you reproduce the behavior in the SDK UI or in the admin agent? If yes, then please open a bug with specific steps (ie, a site to connect to, what to install, etc.).

Note that PreselectedIUInstallWizard is only used in the SDK as the error page of the install wizard, so it's possible that we don't have the same scenario you do in the SDK.

The admin agent uses PreselectedIUInstallWizard when you select items in the metadata repository viewer and choose install. Since this code is not exercised as much, it's possible that there's something missing in PreselectedIUInstallWizard.

If you can't reproduce in either the SDK or agent, then you could still open a bug including a code snippet that shows how you are launching the wizard...

susan

<David.Dubrow@xxxxxxxxx>

<David.Dubrow@xxxxxxxxx> Sent by: p2-dev-bounces@xxxxxxxxxxx 05/14/2009 07:13 AM Please respond to P2 developer discussions

To: <p2-dev@xxxxxxxxxxx> cc: Subject: [p2-dev] WizardWithLicenses enables finish before accepting license

I couldn’t find an existing bugzilla addressing this but wanted to check here first.

I am currently calling PreselectedIUInstallWizard and I don’t know whether this is an issue with the other wizards as well but it may be. In any case, the problem is that due to the ordering of calls between when the license page is added by WizardWithLicenses.getNextPage() and when canFInish() is called causes the finish button to be enabled prior to the user accepting licenses even though a license is provided by selected IUs. Of course, this allows users to install Ius without accepting the license. If next is pressed rather than finish, then the finish button is correctly disabled until the user accepts the license.

If you want me to log this bugzilla, please let me know.

TIA,

--David Dubrow
david.dubrow@xxxxxxxxx

_______________________________________________
p2-dev mailing list
p2-dev@xxxxxxxxxxx
https://dev.eclipse.org/mailman/listinfo/p2-dev