[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index] [List Home]
Re: [p2-dev] newbie committer question

Thanks, and (merde) - I made some commits, and included the bugzilla URL's.
Should I somehow go back and modify the checkin comments?


On Apr 14, 2009, at 5:00 PM, Susan Franklin McCourt wrote:

Also, put the bug number and title of the bug in the commit comment.
Such as
Bug 300000 - [transport] Henrik please fix all our transport bugs

The releng tool uses this when creating the list of bugs that were fixed.

susan
<graycol.gif>Pascal Rapicault <Pascal_Rapicault@xxxxxxxxxx>


<ecblank.gif>
<ecblank.gif>
<ecblank.gif>

To: P2 developer discussions <p2-dev@xxxxxxxxxxx>
cc: P2 developer discussions <p2-dev@xxxxxxxxxxx>, p2-dev-bounces@xxxxxxxxxxx
Subject: Re: [p2-dev] newbie committer question


- Write a test (actually this should happen before you commit :-))
- Updating the iplog when you are committing code that you did not author. If the contribution is less than 200 lines of code, you just need to flag the patch with the iplog option (in bugzilla details > iplog), if it is larger than 200 lines of code, then you want to open a CQ.
- Also if you are releasing large changes, make sure to tag the projects impacted before and after the commit in case it needs to be reverted.

Welcome on board,

PaScaL

<graycol.gif>Henrik Lindberg ---04/14/2009 10:21:31 AM---As a new committer (woo hoo !!) I just made the first p2 commit (a very small bugfix https://bugs.
<ecblank.gif>
From:
<ecblank.gif>
Henrik Lindberg <henrik.lindberg@xxxxxxxxxxxxxx>
<ecblank.gif>
To:
<ecblank.gif>
P2 developer discussions <p2-dev@xxxxxxxxxxx>
<ecblank.gif>
Date:
<ecblank.gif>
04/14/2009 10:21 AM
<ecblank.gif>
Subject:
<ecblank.gif>
[p2-dev] newbie committer question





As a new committer (woo hoo !!) I just made the first p2 commit (a  
very small bugfix
https://bugs.eclipse.org/bugs/show_bug.cgi?id=272142).
Are there more things I should do after having committed something to  
HEAD? (I know about iplog and IP issues when handling patches).

Henrik Lindberg
henrik.lindberg@xxxxxxxxxxxxxx

_______________________________________________
p2-dev mailing list
p2-dev@xxxxxxxxxxx

https://dev.eclipse.org/mailman/listinfo/p2-dev

_______________________________________________
p2-dev mailing list
p2-dev@xxxxxxxxxxx
https://dev.eclipse.org/mailman/listinfo/p2-dev
_______________________________________________
p2-dev mailing list
p2-dev@xxxxxxxxxxx
https://dev.eclipse.org/mailman/listinfo/p2-dev

GIF image