[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index] [List Home]
Re: [p2-dev] why is it not enough to just listen for removed files

ok.  Thanks for the explanation Simon.  Makes sense.  Off the top of my head it looks interesting to factor this out.  Seems like most users of the watcher/listener structure will get bitten by this.

Jeff

Simon Kaegi wrote:

The DirectoryWatcher does not track file deletions between runs. e.g. "scannedFiles" is computed based on the current run and is not persisted.
The RepositoryListener on the other-hand does perists ius/artifact descriptors between runs so needs to verify everything in its repo is polled/on disk.

I'm a bit undecided if it's better to track persistence in a listener or in a specialized directory watcher but for now we're doing it in a listener. We could factor that out to a common listener super class fairly easily.
-Simon
p2-dev-bounces@xxxxxxxxxxx wrote on 09/10/2008 05:20:40 PM:

> [image removed]

>
> [p2-dev] why is it not enough to just listen for removed files

>
> Jeff McAffer

>
> to:

>
> P2 developer discussions

>
> 09/10/2008 05:21 PM

>
> Sent by:

>
> p2-dev-bounces@xxxxxxxxxxx

>
> Please respond to P2 developer discussions

>
> in the RepositoryListener there is code that deals with polledSeenFiles
> etc .  it seems to be there as a compensation for a failing it the
> directory watcher where it is not reporting all removed files.  Anyone
> got an idea what that failing is and how we can address it?  otherwise
> everyone who uses the dir watcher will have the same problem.
>
> Jeff
> _______________________________________________
> p2-dev mailing list
> p2-dev@xxxxxxxxxxx
> https://dev.eclipse.org/mailman/listinfo/p2-dev


_______________________________________________ p2-dev mailing list p2-dev@xxxxxxxxxxx https://dev.eclipse.org/mailman/listinfo/p2-dev