Re: [orion-dev] continute

["Balan, Yossi" <yossi.balan@xxxxxxx>]

Hi

 

Do you have any update for this change ?

 

Regards,

Yossi

 

From: Balan, Yossi
Sent: Tuesday, September 22, 2015 8:38 AM
To: orion-dev@xxxxxxxxxxx
Subject: RE: [orion-dev] continute

 

Hi John

 

Thanks for the help.

Do you submit my change ? https://git.eclipse.org/r/#/c/51423/

Or I need to do more changes ?

 

Regards,

Yossi

 

 

From: orion-dev-bounces@xxxxxxxxxxx [mailto:orion-dev-bounces@xxxxxxxxxxx] On Behalf Of John Arthorne
Sent: Monday, September 21, 2015 11:42 PM
To: orion-dev@xxxxxxxxxxx
Cc: orion-dev@xxxxxxxxxxx
Subject: Re: [orion-dev] continute

 

Hi Yossi,

 

Yes it is not problem asking questions on the mailing list!

 

The best practice for Gerrit is to continue using the same change id when making subsequent commits for the same issue. You create 3 separate change ids for the different iterations of the fix so I abandoned the two older ones.

 

John

 

----- Original message -----
From: "Balan, Yossi" <yossi.balan@xxxxxxx>
Sent by: orion-dev-bounces@xxxxxxxxxxx
To: Orion developer discussions <orion-dev@xxxxxxxxxxx>
Cc:
Subject: Re: [orion-dev] continute
Date: Mon, Sep 21, 2015 3:33 PM
 

Hi Jhon

 

Thanks for the help and for the answers.

One thing about the change I create 3 patch set because the comment of Silenio Quarti.

https://git.eclipse.org/r/#/c/51423/

you did Abandoned because it is duplicate.

Is it ok ?

Is it ok to ask those question in this mail list ?

 

Regards,

Yossi

 

From: orion-dev-bounces@xxxxxxxxxxx [mailto:orion-dev-bounces@xxxxxxxxxxx] On Behalf Of John Arthorne
Sent: Monday, September 21, 2015 4:44 PM
To: orion-dev@xxxxxxxxxxx
Subject: Re: [orion-dev] continute

 

Hi Yoshi,

 

1. There is nothing more you needed to do here. However sending your gentle reminder was a good idea - sometimes these things just fall off the radar. Especially in this case because there was no evident bug or adverse user behavior. We'll try to get it reviewed ASAP.

 

2. We don't actually run maintenance builds for previous releases of Orion. Once it is accepted in master you could also submit a change against an older branch if it is helpful for you, but you will have to take care of building that old branch yourself.

 

3. Yes it is possible to only make the change against an older branch, but we like to avoid it. if it makes sense to change it in Orion 5, it is hard to argue we shouldn't also do it in the latest release. Otherwise you or others would hit a regression when moving up to a newer release.

 

John

 

----- Original message -----
From: "Balan, Yossi" <yossi.balan@xxxxxxx>
Sent by: orion-dev-bounces@xxxxxxxxxxx
To: "orion-dev@xxxxxxxxxxx" <orion-dev@xxxxxxxxxxx>
Cc:
Subject: [orion-dev] continute
Date: Mon, Sep 21, 2015 3:26 AM
 

Hi All

 

I am new on all the contribution process and I have few questions :

1.       I did the process and fix bug 468485 with this correction - https://git.eclipse.org/r/#/c/52033/ but I still didn’t merge . do I need to do more steps ?

2.       About this correction I fixed it on orion8 does it will be updated also orion5 / 9/ 10 ?

3.       Is it possible to fix only for orion 5?

 

Regards,

Yossi

_______________________________________________
orion-dev mailing list
orion-dev@xxxxxxxxxxx
To change your delivery options, retrieve your password, or unsubscribe from this list, visit
https://dev.eclipse.org/mailman/listinfo/orion-dev

 

 

_______________________________________________
orion-dev mailing list
orion-dev@xxxxxxxxxxx
To change your delivery options, retrieve your password, or unsubscribe from this list, visit
https://dev.eclipse.org/mailman/listinfo/orion-dev