[orion-dev] authentication issues

[Michal Wlodarczyk <mwlodarczyk@xxxxxxxxxxxx>]

Hi,

I have been working with the Orion authentication code lately and I have noticed two things that might be bugs but I am not sure.

1. The parameter orion.auth.registration.uri (web-ide.conf) seems never used except for the function org.eclipse.orion.client.ui/web/mixloginstatic/_javascript_/common.js:checkUserCreationEnabled() but it is only checked if it is set (if just prevents a redirection).
2. The implementation of org.eclipse.orion.client.ui/web/plugins/authenticationPlugin.js:registerServiceProviders().getUser() seems messed up. The return value is expected to be a promise but when it is resolved, a dictionary object gets assigned to the variable loginData and sometimes the function returns a dictionary. No errors propagate to the higher layers but I think the design of that library should be changed.

I will be happy to read your suggestions.

Best Regards,

Michal Wlodarczyk