Skip to main content

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index] [List Home]
Re: [orion-dev] Contributing to Orion

In general, I find that Gerrit reviews that don't mention a specific "Bug xxxxx" number can easily get missed. They show up in Gerrit, and they generate emails that can be subscribed to, but not every committer checks these on a regular basis (although we all really should). Whereas if a bug number is mentioned, the system will link it to the bug, producing a bugzilla email which most people will see.

So if you are submitting a review without a bug, it might be a good idea to call attention to it with a post on the orion-dev list or the forum. Especially if it's a substantial change.

And Orion committers: please make sure you go to https://git.eclipse.org/r/#/settings/projects and "watch" for New Change Sets in the projects that start with orion/. This will deliver emails when changes arrive through Gerrit. We should also subscribe to the GitHub projects: orion.client and orion.server since people sometimes open pull requests there.

Mark

On Thu, Aug 27, 2015 at 4:59 PM, Anthony Hunter <anthonyh@xxxxxxxxxx> wrote:

Hi Andrew,

This is normal. I have reviewed a couple and they have been merged.

I need to test the other OAuth changes in more detail. I should be able to do that in the next while.

Cheers...
Anthony


Inactive hide details for Andrew Audibert ---2015/08/27 04:14:12 PM---What is the normal turnaround time for Gerrit commits? IAndrew Audibert ---2015/08/27 04:14:12 PM---What is the normal turnaround time for Gerrit commits? I’ve built up quite a few commits in the last

From: Andrew Audibert <aaudibert@xxxxxxxxxxxx>
To: "orion-dev@xxxxxxxxxxx" <orion-dev@xxxxxxxxxxx>
Date: 2015/08/27 04:14 PM
Subject: Re: [orion-dev] Contributing to Orion
Sent by: orion-dev-bounces@xxxxxxxxxxx





What is the normal turnaround time for Gerrit commits? I’ve built up quite a few commits in the last week without any reviewer interaction. Is this normal, or should I be doing something differently?

-Andrew_______________________________________________
orion-dev mailing list
orion-dev@xxxxxxxxxxx
To change your delivery options, retrieve your password, or unsubscribe from this list, visit
https://dev.eclipse.org/mailman/listinfo/orion-dev


_______________________________________________
orion-dev mailing list
orion-dev@xxxxxxxxxxx
To change your delivery options, retrieve your password, or unsubscribe from this list, visit
https://dev.eclipse.org/mailman/listinfo/orion-dev


Back to the top