Re: [orion-dev] need committer reviewing fix for https://bugs.eclipse.or

[John Arthorne <John_Arthorne@xxxxxxxxxx>]

I intended to comment in the bug, but I
also did a quick review of it yesterday and was nervous about putting it
in. The release review ends tomorrow and we will be announcing availability
of the release this week, so it feels very last minute for a bug that is
annoying in that particular case, but not really doing any damage.

John




From:      
 Simon Kaegi/Ottawa/IBM@IBMCA
To:      
 Orion developer discussions
<orion-dev@xxxxxxxxxxx>, 
Date:      
 02/25/2014 12:01 AM
Subject:    
   Re: [orion-dev]
need committer reviewing fix        for  
     https://bugs.eclipse.org/bugs/show_bug.cgi?id=428733
Sent by:    
   orion-dev-bounces@xxxxxxxxxxx

---

Hi Matthias, (and Michael)
Thanks for the patch. I took an initial look at the patch and the bug report
and obviously the problem is valid and confusing to users. My concern is
that we're essentially done 5.0 and waiting for the release review and
I'm not certain this is either a blocker or a trivially correct fix at
this point.
We can talk more in the bug as I wonder what would be involved in fixing
this in the client vs the server and once that's sorted we can decide what
to do. I'm still hesitant but if we are going to do something it really
needs to be tomorrow.
-Simon

Matthias
Sohn ---02/24/2014 05:22:00 PM---I'd like to ensure that https://git.eclipse.org/r/#/c/22364/

From:	Matthias Sohn <matthias.sohn@xxxxxxxxx>
To:	Orion developer discussions <orion-dev@xxxxxxxxxxx>,
Date:	02/24/2014 05:22 PM
Subject:	[orion-dev] need committer reviewing fix for https://bugs.eclipse.org/bugs/show_bug.cgi?id=428733
Sent by:	orion-dev-bounces@xxxxxxxxxxx

---

I'd like to ensure that
https://git.eclipse.org/r/#/c/22364/
reaches 5.0. 

Any other committer who could also review that change ?

It's fixing an ugly misbehavior which occurs when cloning a repository
through "New > Project > Git Repository" from the Orion
Content Page.
This doesn't copy user name and email to the new repository's git configuration
(which is done when cloning from the "All Git Repositories" page.
Then the user has to manually enter his name and email (twice) when
committing a change since the configuration is missing which is annoying
and pretty confusing to the users. Michael's patch is fixing this problem.

--
Matthias_______________________________________________
orion-dev mailing list
orion-dev@xxxxxxxxxxx
https://dev.eclipse.org/mailman/listinfo/orion-dev

_______________________________________________
orion-dev mailing list
orion-dev@xxxxxxxxxxx
https://dev.eclipse.org/mailman/listinfo/orion-dev