Skip to main content
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index] [List Home]
Re: [orion-dev] Using es5-shim.js license question
As far as I know, yes, the Function.bind function is the only issue here. I'll fish out the implementation inside the editor and try to use that instead of
es5-shim.js. That's probably better than put in a new dependency on es5-shim.js.

Thanks for the pointers and detailed info,

Kris

Hi Kris,

Is the issue just Function.bind -- if so I think we already have a shim in org.eclipse.orion.client.editor/web/orion/editor/editor.js (line 853) that we could separate out and use.
FWIW this is an issue that we're most definitely aware of ... see https://bugs.webkit.org/show_bug.cgi?id=26382 -- It's actually fixed now so hopefully we'll see it the next release of Safari.
Also see -- http://kangax.github.com/es5-compat-table/

Safari is the only browser not to provide an implementation of Function.bind and what's more across the browsers we try to support this is also the only real missing piece of es5 functionality. So... I noticed that while submitting the CQ but really do not want to introduce something like the es5-shim unless we really need to (as an aside, the license is fine but the issue is nearly always determining provenance).

-Simon

Inactive hide details for Kris De Volder ---03/12/2012 05:06:07 PM---We've found that gcli interface isn't working on Safari. PKris De Volder ---03/12/2012 05:06:07 PM---We've found that gcli interface isn't working on Safari. Problem is some missing ECMA-5 function cal


    From:

Kris De Volder <kdvolder@xxxxxxxxxx>

    To:

Orion developer discussions <orion-dev@xxxxxxxxxxx>

    Date:

03/12/2012 05:06 PM

    Subject:

[orion-dev] Using es5-shim.js license question

    Sent by:

orion-dev-bounces@xxxxxxxxxxx




We've found that gcli interface isn't working on Safari. Problem is some missing ECMA-5 function called 'bind'.

Gcli demo code deals with this situation by loading up a copy of this script to bring browser up to spec:
https://raw.github.com/kriskowal/es5-shim/master/es5-shim.js

I want to include a copy of this script also with our orion-gcli code...

It has MIT license.

Questions
1) is this license ok?
2) do we need to start the legal process for getting approval for this piece of code?

Kris
_______________________________________________
orion-dev mailing list
orion-dev@xxxxxxxxxxx
https://dev.eclipse.org/mailman/listinfo/orion-dev




_______________________________________________
orion-dev mailing list
orion-dev@xxxxxxxxxxx
https://dev.eclipse.org/mailman/listinfo/orion-dev

Attachment: graycol.gif
Description: GIF image

Attachment: ecblank.gif
Description: GIF image

Back to the top