Skip to main content

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index] [List Home]
Re: [orion-dev] Editor changes - removing the IFRAME


The bug that made me decide to remove the IFRAME is [1], but Felipe and I have been thinking about it for a long time.  There have been other issues directly related to the IFRAME that made us think this was the right direction. The whole asynchronous loading of the view is one of them. Without the IFRAME this is not an issue anymore and a lot of code could be removed.

All the work was done in this branch "editorNoIFRAME". It has too many commits to list here.

[1] https://bugs.eclipse.org/bugs/show_bug.cgi?id=371646

Silenio


From: "Mihai Sucan" <msucan@xxxxxxxxxxx>
To: "Orion developer discussions" <orion-dev@xxxxxxxxxxx>, Silenio Quarti/Ottawa/IBM@IBMCA
Date: 03/09/2012 06:06 AM
Subject: Re: [orion-dev] Editor changes - removing the IFRAME





Hello Silenio!


Le Thu, 08 Mar 2012 23:17:59 +0200, Silenio Quarti  
<Silenio_Quarti@xxxxxxxxxx> a écrit:

> I have merged the changes to remove the IFRAME that hosts the editor into
> master.
>
> Unfortunately, some APIs in TextView had to be removed since they only
> made sense because of the IFRAME.  Hopefully I have updated all the  
> places
> that made use of them in Orion. Please let me know if I missed any.  
> Sorry
> about other users of the editor. Let me know if you need help updating.

This is a quite important change. Can you please point us to the relevant  
bug where these changes landed? I'd also like to see the commits.


Thank you!



Best regards,
Mihai




Back to the top