Re: [orion-dev] heads up: command framework API/sweeping changes

[Kris De Volder <kdvolder@xxxxxxxxxx>]

Not sure this is connected or not... But I seem to be having trouble opening files from the navigator.
When I click on a file in the navigator... it just shows the file contents instead of opening an editor on the file.

E.g. I click on a file called 'app.js' and I get redirected to this URL: http://localhost:8080/file/K/app.js
instead of an 'edit' URL like http://localhost:8080/edit/edit.html#/file/K/app.js

Kris

---

hello, all.
In the interest of getting low level/client affecting changes in early, and in letting people know about them, I'd like to let you know that I just released a big set of changes involving command framework API, internal representation, and asynchronous rendering of some commands. [1]

I attempted to change every single client page and related scripts, and I attempted to open and test the commands on every single page.
However, there is a bug [2] that prevents me from testing the site page, so I could not verify that it is working properly.

So.....

Ken/John - could you please verify the "edit site" page opens and operates correctly before promoting tonight's build
Everyone Else - please do a sanity check on your pages. I did my best to cover them all but I have never been completely successful.

The API changes greatly simplify the handling of scopes and reduce the number of commands iterated when rendering.
In a nutshell, you should no longer have to declare a scope when defining and adding a command to the command service. Instead, you must always identify a contribution scope when rendering the commands.
See this bug/comment [3] for more detail.

susan


[1] https://bugs.eclipse.org/bugs/show_bug.cgi?id=370014
[2] https://bugs.eclipse.org/bugs/show_bug.cgi?id=369433
[3] https://bugs.eclipse.org/bugs/show_bug.cgi?id=370014#c8
_______________________________________________
orion-dev mailing list
orion-dev@xxxxxxxxxxx
https://dev.eclipse.org/mailman/listinfo/orion-dev