Skip to main content

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index] [List Home]
Re: [orion-dev] Hiding pageToolbar

It's not dojo per se it's "fixed vs. fluid" vertically. CSS fixed positioning tells the browser "I know better."
We do pinning of the header and footer, and we also pin the toolbar (John's issue).
We happen to use dojo BorderContainer to achieve this, but we could also be doing math and managing it ourself. Either way, when you use fixed positioning you've given up any "free flow" from the browser and thus if you change something requiring more/less space, like hiding an element, the browser won't flow the content. You need to explicitly make that happen.

For fluid headers and footers (that can scroll off the page) none of this is needed. If we allowed toolbars to scroll out of view when content scrolls, we wouldn't have had John's issue.

Why do we do this? My best recollection is that it started with the editor.
You have the notion of wanting a header, footer, and "everything else for the editor." And we did not want browser scrollbars to the right of an editor scrollbar. So given those constraints, pinning the header and footer for the editor and giving the editor the rest, makes sense. Any other solution opens up the "double scrollbar problem.)

But I think it's valid to question whether we want to do this on other pages where the content simply gets larger and larger and we use the browser scrollbar.
If everything is fluid, we would just have to make sure we had a story for notifications and status messages (right now they appear in the toolbar which we know will be visible).
I think it's worth considering (post 0.4). I personally do not like having to assume a layout manager for our pages, and it might make sense to only do so for the editor.

susan

Inactive hide details for Mike Wilson ---01/31/2012 07:32:26 AM---> ... but such is life as long as we are using fixed headers Mike Wilson ---01/31/2012 07:32:26 AM---> ... but such is life as long as we are using fixed headers and footers. Really? Is this some Dojo

From: Mike Wilson <Mike_Wilson@xxxxxxxxxx>
To: Orion developer discussions <orion-dev@xxxxxxxxxxx>
Date: 01/31/2012 07:32 AM
Subject: Re: [orion-dev] Hiding pageToolbar
Sent by: orion-dev-bounces@xxxxxxxxxxx





> ... but such is life as long as we are using fixed headers and footers.
Really? Is this some Dojo artifact? I've certainly seen the display:none pattern work (for headers at least) before.

McQ.

Inactive hide details for John J Barton ---2012/01/30 17:56:21---On Mon, Jan 30, 2012 at 2:41 PM, Susan Franklin McCourt <John J Barton ---2012/01/30 17:56:21---On Mon, Jan 30, 2012 at 2:41 PM, Susan Franklin McCourt <

From:

John J Barton <johnjbarton@xxxxxxxxxxxxxxx>

To:

Orion developer discussions <orion-dev@xxxxxxxxxxx>

Date:

2012/01/30 17:56

Subject:

Re: [orion-dev] Hiding pageToolbar






On Mon, Jan 30, 2012 at 2:41 PM, Susan Franklin McCourt <
susan_franklin@xxxxxxxxxx> wrote:
      hi, John. Are you observing that the toolbar disappears but you don't get the content back?

The pixels in the toolbar area are blank, but I want the area to be gone.
 
      you'll need to force a new layout.
      mUtil.forceLayout(toolbar)


That works, thanks!
jjb
_______________________________________________
orion-dev mailing list
orion-dev@xxxxxxxxxxx

https://dev.eclipse.org/mailman/listinfo/orion-dev

_______________________________________________
orion-dev mailing list
orion-dev@xxxxxxxxxxx
https://dev.eclipse.org/mailman/listinfo/orion-dev

GIF image

GIF image


Back to the top