[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index] [List Home]
Re: [orion-dev] searchClient.js

>A clean solution would be to have a way to decouple the collecting of the results from how they are presented.  This way we can handle the presentation in one >location (like a label provider in the Eclipse world).  If this seems reasonable, I can work with Kris on a good implementation since this seems to span an area that >we are both working on.


seems very reasonable to me, Andrew.
As for where it should live....maybe some new js file associated with rendering orion resource objects. (renderers.js? resourceRendering.js?)
We have a some UI generation utility methods in org.eclipse.orion.client.core/web/orion/util.js but that is all static stuff.

If you look at the various *explorer.js files scattered around the navigator, search, git, you'll see that we do some rendering of resource objects there a lot, and unfortunately we copy a lot of that code around. So a longer term goal could be to have this stuff also be useful in the explorer renderers too.

I'd be happy to review or provide input as I think having favorites accessible from any page is important for 0.4

susan

Inactive hide details for Andrew Eisenberg ---01/25/2012 09:17:36 AM---I've been looking at https://bugs.eclipse.org/bugs/show_Andrew Eisenberg ---01/25/2012 09:17:36 AM---I've been looking at https://bugs.eclipse.org/bugs/show_bug.cgi?id=347058, getting favorites to appe

From: Andrew Eisenberg <andrew@xxxxxxxxxxxx>
To: Orion developer discussions <orion-dev@xxxxxxxxxxx>
Date: 01/25/2012 09:17 AM
Subject: Re: [orion-dev] searchClient.js
Sent by: orion-dev-bounces@xxxxxxxxxxx





I've been looking at https://bugs.eclipse.org/bugs/show_bug.cgi?id=347058, getting favorites to appear in the open resources dialog.  The problem that I am going to have is that the presentation of the search results is wrapped up in the implementation of searchClient.js.  I am going to want to present the favorites the same way as search results are presented, but this means I will have to copy the UI code somewhere so both favorites and search results will look the same in the open resources dialog.  This seems unfortunate to me.

A clean solution would be to have a way to decouple the collecting of the results from how they are presented.  This way we can handle the presentation in one location (like a label provider in the Eclipse world).  If this seems reasonable, I can work with Kris on a good implementation since this seems to span an area that we are both working on.

On Wed, Jan 25, 2012 at 8:13 AM, Susan Franklin McCourt <susan_franklin@xxxxxxxxxx> wrote: _______________________________________________
orion-dev mailing list
orion-dev@xxxxxxxxxxx
https://dev.eclipse.org/mailman/listinfo/orion-dev

GIF image