Well... it's not pretty because the copyright headers end up multiple times in the minified result. I don't know how this can be easily avoided though, since each HTML page will be using a different set of source files.
My proposal would be to make the small and pragmatic change now, and if the comment duplication is hurting performance, we can discuss better solutions then. Sounds reasonable to me. I'm curious to
see what this looks like when you concat multiple source files that all
have licenses. But you're right that our current state is we distribute
minified _javascript_ files with no copyright/license text at all, so this
would definitely be an improvement.
John
I would like to add JSDoc "@license" tags
to the Orion _javascript_
source code. Does anybody see a problem with that? The reasoning goes
as follows:
1. If you decide to use the Orion client source code under the EDL
terms [1], redistributions of source code (with or without
modification) must retain the copyright notice.
2. It is common to use minifiers or "compilers" to modify the
source
code in a way that it ends up being smaller and faster to download.
But you're still going to distribute the result in source form, so
copyright notices should be retained where normally the minification
would get rid of comments.
3. Some minifiers [2] can automate this based on the presence of a
JSDoc "@license" tag. Orion is using JSDoc already, so adding
this tag
seems like a reasonable thing to do.
Makes sense? If yes, I'd be happy to make the changes.
Thanks,
Boris
[1] http://www.eclipse.org/org/documents/edl-v10.html
[2] http://code.google.com/closure/compiler/faq.html#license
_______________________________________________
orion-dev mailing list
orion-dev@xxxxxxxxxxx
https://dev.eclipse.org/mailman/listinfo/orion-dev
|