Skip to main content

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index] [List Home]
Re: [orion-dev] Managing branches

On Wed, Jun 15, 2011 at 9:50 AM, Felipe Heidrich <Felipe_Heidrich@xxxxxxxxxx> wrote:
Hi John,

What is "the git way" to handle code review ?

I know git has commands like git-format-patch and git-am to send and receive patch via email, is that what the average git developer is using ?

The kernel devs do this and it's a bit crazy imho :)
 
What about people using git + bugzilla ?
(can I use git-format-patch to prepare a patch to bugzilla and git-am to apply the patch from bugzilla.)


Something else I saw (while working on https://bugs.eclipse.org/bugs/show_bug.cgi?id=348471 and https://bugs.eclipse.org/bugs/show_bug.cgi?id=334583) are pull requests, is that a github.com feature (is that gerrit) ?

GitHub is popular partially because pull requests and it's network view make it easy to see everyone else's branches...

Take a look at how Gerrit works, I think Alex's video demo is pretty good...
     http://alblue.bandlem.com/2011/02/gerrit-git-review-with-jenkins-ci.html

We use it in EGit/JGit with a lot of success... http://egit.eclipse.org

The foundation is looking to have a Gerrit instance available for everyone, but nothing is set in stone yet... see this bug...
     https://bugs.eclipse.org/bugs/show_bug.cgi?id=283749

--
Cheers,

Chris Aniszczyk
http://aniszczyk.org
+1 512 961 6719

Back to the top