Re: [orion-dev] Managing branches

[Felipe Heidrich <Felipe_Heidrich@xxxxxxxxxx>]

Hi John,

What is "the git way" to handle
code review ?

I know git has commands like git-format-patch
and git-am to send and receive patch via email, is that what the average
git developer is using ?

What about people using git + bugzilla
?
(can I use git-format-patch to prepare
a patch to bugzilla and git-am to apply the patch from bugzilla.)


Something else I saw (while working
on https://bugs.eclipse.org/bugs/show_bug.cgi?id=348471
and https://bugs.eclipse.org/bugs/show_bug.cgi?id=334583)
are pull requests, is that a github.com feature (is that gerrit) ?

Personally I think that using branch
for code review involves too many steps.


Felipe

From:	John Arthorne/Ottawa/IBM@IBMCA
To:	Orion developer discussions <orion-dev@xxxxxxxxxxx>
Date:	06/15/2011 09:29 AM
Subject:	Re: [orion-dev] Managing branches
Sent by:	orion-dev-bounces@xxxxxxxxxxx

---

> John J Barton <johnjbarton@xxxxxxxxxxxxxxx>
> I am thinking about using automatic git branches to support a 
> slightly different work flow in Orion+Firebug. Firebug will be 
> monitoring your changes character at a time. Once Firebug concludes
> that a patch is syntax correct, the edit would be saved to the 
> server on a new branch.  Subsequent changes would be committed
to 
> the branch individually.  When the dev pushes "Save"
it really means
> "merge" the auto branch back to the master (or what ever
is current). 

Pushing to an SCM on edit/save can certainly be handy - we had that in
our tools 15 years ago! The only warning I will give is that the performance
of doing this with Git can be quite bad. We had something like this in
earlier Orion milestones, where our "file system" was actually
a git repository, and we did add/commit/push on every editor save. The
performance was terrible, but I suspect with some work it could be optimized
and/or moved into the background to avoid disruption.

JohnA_______________________________________________
orion-dev mailing list
orion-dev@xxxxxxxxxxx
https://dev.eclipse.org/mailman/listinfo/orion-dev