[orion-dev] Pushed fileClient conversion to plugin

[John Arthorne <John_Arthorne@xxxxxxxxxx>]

I have just pushed a major change to the
client code, so that the file/workspace service is contributed by a plugin.
This technically enables interacting with a workspace stored on a different
server from the tools. I have tested all the basic workflows in Firefox/Chrome/IE
with no major problems. There are some rough edges, but I wanted to get
the changes out so other people can get involved as necessary in tracking
down the remaining issues. Here are some minor problems to watch out for:

 On chrome only, there seems to
be a race condition between login happening in the main window and async
xhr calls from the file plugin. The result is that immediately after logging
in, you may have to hit F5 to see the workspace contents. Once logged in
you shouldn't see any problem requiring manual refresh for the remainder
of the browser session. I haven't seen this problem on FF or IE (https://bugs.eclipse.org/bugs/show_bug.cgi?id=338596).

Error reporting is broken. For example
if you try to access a file that doesn't exist, you'll see the 404 in the
console, but the error message isn't displayed anywhere a typical user
can see it. I traced through this and the error is getting propagated back
to the UI code, which is inserting an element in the document to display
the error, but nothing appears. I don't know if this problem is related
to my changes or if it was already broken (https://bugs.eclipse.org/bugs/show_bug.cgi?id=338598).

Some changes were required to SiteConfigEditor.js
to support this, but I couldn't see any way to test my changes. I have
committed them and hope they work ;) Please ping me if there is a problem
there (and let me know how to run it).

The editor doesn't currently use fileClient.js
to get/put the file contents, so that is currently missing from the plugin
story. I am working on that part next.

If you see any other problems related
to this change, please let me know, and/or enter bugs.