[
Date Prev][
Date Next][
Thread Prev][
Thread Next][
Date Index][
Thread Index]
[
List Home]
|
Re: [orbit-dev] Declaring Build: R20180531190352 (Photon)
|
On 31/05/2018 23:25, Roland Grunberg wrote:
Although the Batik 1.9.1 stack is in, there do appear to
be some issues with certain usages of it affecting some projects. As a
result, Bug 522740 will continue to be worked on.
Regarding this, Martin Lippert has raised some concerns on
cross-projects [1]. Roland, how do you feel about a possible respin of
Orbit where we would remove the parts of the Batik 1.9.1 that we know
are not actually used by anyone?
The only legitimate (and safe) use of v1.9.1 would be the Batik CSS
parser (and its few dependencies) that is used by the platform.
From what I see at [2], the only 1.9.1 JARs actually pulled into the
Photon aggregation at this time are:
* org.apache.batik.constants_1.9.1.v20180227-1645.jar
* org.apache.batik.css_1.9.1.v20180313-1559.jar
* org.apache.batik.dom_1.9.1.v20180313-1559.jar
* org.apache.batik.ext.awt_1.9.1.v20180227-1645.jar
* org.apache.batik.i18n_1.9.1.v20180227-1645.jar
* org.apache.batik.svggen_1.9.1.v20180313-1559.jar
* org.apache.batik.util_1.9.1.v20180227-1645.jar
* org.apache.batik.util.gui_1.9.1.v20180227-1645.jar
* org.apache.batik.xml_1.9.1.v20180227-1645.jar
That's 9 out of 21. The "constants", "css", "util", "i18n" are the ones
needed by the platform, and can stay.
I suspect that the others (dom, ext.awt, svggen, util.gui and xml) are
pulled by either BIRT and/or Graphiti (the list matches the JARs
Graphiti adopted in [3] and has not reverted yet); at least that's my
interepreteation of the aggregation log [4].
* BIRT seems to have made the revert [5] in their source, but their
contribution in the SimRel has not changed (actually, it does not seem
to have changed since Oxygen.0, which seems strange).
* I've contacted Graphiti's lead directly about the situation, he told
me he will revert to the previous Batik for RC3 this week.
* The other projects which were consuming Batik 1.9.1 have all reverted
(GMF Runtime, Sirius and Papyrus) at this time.
I can prepare a patch to orbit-recipes that keeps the JARs as is but
only provide the minimum subset needed by the platform into the
repository if we decide to go that route.
Regards,
Pierre-Charles
[1]
https://dev.eclipse.org/mhonarc/lists/cross-project-issues-dev/msg15633.html
[2]
https://hudson.eclipse.org/simrel/job/simrel.photon.runaggregator.BUILD__CLEAN/lastSuccessfulBuild/artifact/aggregation/final/plugins/
[3]
https://git.eclipse.org/r/c/117172/10/features/org.eclipse.graphiti.export.feature/feature.xml
[4]
https://hudson.eclipse.org/simrel/job/simrel.photon.runaggregator.BUILD__CLEAN/lastSuccessfulBuild/consoleFull
[5]
https://github.com/eclipse/birt/commit/7f924f0d12d65cdc21f83a41a1b0b9f17729f330
