| Re: [orbit-dev] EBR way of patching class from upstream JAR? |
Hi Roland, >>> - What legal requirements are there when I want to do a small (one-line) >>> modification of an upstream bundle? >> >> The CQ where the code was reviewed needs to have the 'modified' flag >> set by legal, along with the exact changes you intend to introduce, and >> under what license they'd be covered/etc. > > There's an issue with this. We would still be shipping Lucene Core > 5.2.1, 6.1.0 as 'unmodified', yet we want to modify it in some other > distribution (likely something targeting Oxygen.1). So I would guess > that we need a separate CQ because one can't represent modified and > unmodified. So we need a separate CQ for a modified Lucene Core 5.2.1. Fine. I just wonder on behalf of which project I should file this CQ, assuming that we would still need a *separate* Add-to-Orbit CQ. Should I file a CQ on behalf of tools.orbit [1] and then, once that is approved, on behalf of tools.orbit another ATO CQ? Seems like a lot of hoops to jump through... > Am I right in assuming that this is just targeting Oxygen.1, or > basically from Orbit's point of view, all that is needed is some > repository that consumers can reference to correct the issue ? Yes, as I explained in Bug 517935 [2] Oxygen won't break out-of-the-box, as it will contain only a single unpatched version of Lucene Core (org.apache.lucene.core_6.1.0). The bug will only manifest if a third-party project also installs the unpatched org.apache.lucene.core_5.2.1. As long as Orbit has at least an I-build with the patched org.apache.lucene.core bundles available, third-party projects have an easy way out; the can simply redistribute our patch org.apache.lucene.core bundles. Then, with Oxygen.1 we can further improve the situation by switching to the patched org.apache.lucene.core_6.1.0 bundle in the simultaneous release. Best wishes, Andreas [1] <https://projects.eclipse.org/projects/tools.orbit/cq/create> [2] <https://bugs.eclipse.org/bugs/show_bug.cgi?id=517935#c6> -- Codetrails GmbH The knowledge transfer company Robert-Bosch-Str. 7, 64293 Darmstadt Phone: +49-6151-276-7092 Mobile: +49-170-811-3791 http://www.codetrails.com/ Managing Director: Dr. Marcel Bruch Handelsregister: Darmstadt HRB 91940
Attachment:
signature.asc
Description: OpenPGP digital signature