Re: [orbit-dev] EBR way of patching class from upstream JAR?

[Roland Grunberg <rgrunber@xxxxxxxxxx>]

On Wed, 2017-06-07 at 16:32 +0200, Andreas Sewe wrote:
> Hi Orbit developers,
> 
> to fix Bug 517935 [1], I had to come up with a patched version of the
> org.apache.lucene.core 5.2.1 and 6.1.0 bundles currently in Orbit.
> 
> Here's my question:
> 
> - What's the "EBR way" to achieve this?

I believe that the change you specified in Gerrit achieves exactly what
you want. The alternative would have been to ship a modified version of
the entire artifact and host it on our own maven repository (orbit-
approved-artifacts). However this approach is better suited for when
the entire artifact has significant changes.

CC'ing Gunnar in case I'm missing something.

> 
> - What legal requirements are there when I want to do a small (one-line)
> modification of an upstream bundle?

The CQ where the code was reviewed needs to have the 'modified' flag
set by legal, along with the exact changes you intend to introduce, and
under what license they'd be covered/etc.

Also, there would need to be some form of commitment to ensure that the
change makes it into the upstream project (if it hasn't already) as
continuing to ship with our own personal modifications of the code
itself isn't ideal.

> Please have a look at this change in Gerrit [2]. Is making the one-line
> change directly in a copy of the upstream class OK, or should I make use
> of the maven-patch-plugin [3] or similar to make explicit what my change
> is and what comes straight from the upstream project.

> [1] <https://bugs.eclipse.org/bugs/show_bug.cgi?id=517935>
> [2] <https://git.eclipse.org/r/98804/>
> [3] <https://maven.apache.org/plugins/maven-patch-plugin/>

I think this is ok. In fact mongodb 3.2.2 has exactly such a change.
Have a look at https://dev.eclipse.org/ipzilla/show_bug.cgi?id=12344 .

Am I right in assuming that this is just targeting Oxygen.1, or
basically from Orbit's point of view, all that is needed is some
repository that consumers can reference to correct the issue ?

Cheers,
-- 
Roland Grunberg