Skip to main content
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index] [List Home]
Re: [orbit-dev] How to get version 5.1.0 of ASM in Orbit
Hi Roland,

Thank you for your comments.
I went ahead and prepared change for new repository - https://git.eclipse.org/r/79467
And seems that you right - ATO should be filed by Orbit committer, so that currently this change contains wrong CQ id in ip_log.xml files ( id for piggyback ) , will be glad to fix this if someone can file ATO.

Regarding upgrade from 5.0.1 to 5.1.0: if my memory is correct, then it should be simple - increase version plus fix few easy warnings about usage of deprecated APIs around method handles ( as an example - https://github.com/jacoco/jacoco/commit/8e73ea6aa7ba38a596f60e2180c8c4406c658dc5 ). Alternatively if bundles from CVS are not merged into final repository, could migrate older version(s).

Let me know if I can help more on this subject.

Best regards,
Evgeny


On Mon, Aug 22, 2016 at 3:48 PM Roland Grunberg <rgrunber@xxxxxxxxxx> wrote:
> For the https://projects.eclipse.org/projects/technology.eclemma we need ASM
> 5.1.0 from Eclipse Orbit. This does not seem to be required for EclEmma
> initial contribution, but anyway will be required for first release.
>
> Orbit can use piggyback CQ since this version was already approved -
> https://dev.eclipse.org/ipzilla/show_bug.cgi?id=11234

Sounds good. For inclusion into Orbit, someone would just need to file an
ATO (add to orbit CQ) and I believe they'd need to be an Orbit committer
to do so.

I definitely welcome such a change mainly because it may allow us to replace
the old content (5.0.1) with the new one (5.1.0) for newer builds (assuming
consumers of 5.0.1 can migrate)

Are there any current Orbit committers that would be interested in taking
this ?


>
> Also could be noted that as of today for EclEmma transitively thru JaCoCo we
> try to use most recent versions of ASM, so most likely there will be demand
> for a new versions in Orbit in future and we are ready to do our best with
> contributions to help get them in.

Great, so I would say it makes sense to nominate an existing committer from
technology.eclemma to become an Orbit committer so they can maintain this
work.


>
> For the 5.1.0 I've prepared all the materials based on existing CVS branch
> for version 5.0.1 as an example, also including some minor cleanups - see
> attachment of https://bugs.eclipse.org/bugs/show_bug.cgi?id=499638 I saw
> that there is a new way of managing builds of bundles for Orbit, so can
> prepare using it, if there is demand to move ASM bundle on new way. In
> either case since EclEmma project has no committers in Orbit, we need some
> help to finish this work.

Orbit CVS should have been switched to read-only making orbit-recipes that
way to get content into Orbit going forward. Instructions are in the
repository [1], and there are also commits that show roughly what content
gets pushed and how it looks.

Cheers,
--
Roland Grunberg

[1] https://git.eclipse.org/c/orbit/orbit-recipes.git/tree/README.md
_______________________________________________
orbit-dev mailing list
orbit-dev@xxxxxxxxxxx
To change your delivery options, retrieve your password, or unsubscribe from this list, visit
https://dev.eclipse.org/mailman/listinfo/orbit-dev

Back to the top